Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2307953002: Adding client side field trial for sampling on non-stable channels. (Closed)

Created:
4 years, 3 months ago by jwd
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding client side field trial for sampling on non-stable channels. BUG=642086 Committed: https://crrev.com/1a4be06b817d63f6461d5b6191040b298ae22437 Cr-Commit-Position: refs/heads/master@{#416653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_services_manager_client.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_services_manager_client.cc View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jwd
4 years, 3 months ago (2016-09-02 15:58:25 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-02 18:14:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307953002/1
4 years, 3 months ago (2016-09-06 16:29:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 17:46:29 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 17:50:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a4be06b817d63f6461d5b6191040b298ae22437
Cr-Commit-Position: refs/heads/master@{#416653}

Powered by Google App Engine
This is Rietveld 408576698