Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: net/quic/core/quic_connection.h

Issue 2307933003: Quic: add unittests for reduced PING Timeout (Closed)
Patch Set: address rch's nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection.h
diff --git a/net/quic/core/quic_connection.h b/net/quic/core/quic_connection.h
index e4cb2f82735a714c98567178247ecffa5806e0e5..d5082c50ecb95b4385ad8d038d661d11a9eae605 100644
--- a/net/quic/core/quic_connection.h
+++ b/net/quic/core/quic_connection.h
@@ -483,11 +483,13 @@ class NET_EXPORT_PRIVATE QuicConnection
debug_visitor_ = debug_visitor;
sent_packet_manager_->SetDebugDelegate(debug_visitor);
}
+ // Used in Chromium, but not internally.
+ // Must only be called before ping_alarm_ is set.
void set_ping_timeout(QuicTime::Delta ping_timeout) {
+ DCHECK(!ping_alarm_->IsSet());
ping_timeout_ = ping_timeout;
}
const QuicTime::Delta ping_timeout() { return ping_timeout_; }
- // Used in Chromium, but not internally.
void set_creator_debug_delegate(QuicPacketCreator::DebugDelegate* visitor) {
packet_generator_.set_debug_delegate(visitor);
}
« no previous file with comments | « no previous file | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698