[Interpreter] Collect allocation site feedback in call bytecode handler.

src/builtins/ia32/builtins-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_IA32
 
 #include "src/code-factory.h"
 #include "src/codegen.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 743 matching lines @@
                                                       tail_call_mode),
             RelocInfo::CODE_TARGET);
   } else {
     DCHECK_EQ(function_type, CallableType::kAny);
     __ Jump(masm->isolate()->builtins()->Call(ConvertReceiverMode::kAny,
                                               tail_call_mode),
             RelocInfo::CODE_TARGET);
   }
 }
 
-// static
-void Builtins::Generate_InterpreterPushArgsAndConstructImpl(
-    MacroAssembler* masm, CallableType construct_type) {
-  // ----------- S t a t e -------------
-  //  -- eax : the number of arguments (not including the receiver)
-  //  -- edx : the new target
-  //  -- edi : the constructor
-  //  -- ebx : allocation site feedback (if available or undefined)
-  //  -- ecx : the address of the first argument to be pushed. Subsequent
-  //           arguments should be consecutive above this, in the same order as
-  //           they are to be pushed onto the stack.
-  // -----------------------------------
+namespace {
 
+// Does not assume any free registers. Maintains all registers in their
+// original state on return.
+void Generate_InterpreterPushArgsAndReturnAddress(MacroAssembler* masm,
+                                                  bool is_receiver_available) {

[rmcilroy, 2016/09/06 10:59:35]

Could you pass the registers which are used as arguments

[mythria, 2016/09/07 08:59:44]

Done.

   // Store edi, edx onto the stack. We need two extra registers
   // so store edi, edx temporarily on stack.
   __ Push(edi);
   __ Push(edx);
 
   // We have to pop return address and the two temporary registers before we
   // can push arguments onto the stack. we do not have any free registers so
   // update the stack and copy them into the correct places on the stack.
   //  current stack    =====>    required stack layout
   // |             |            | edx           | (2) <-- esp(1)
@@ skipping 43 matching lines @@
   __ mov(Operand(esp, 0), edi);
 
   // Step 3 move edi to the correct location
   __ mov(edi, Operand(esp, eax, times_pointer_size, 2 * kPointerSize));
   __ mov(Operand(esp, 1 * kPointerSize), edi);
 
   // Step 4 move return address to the correct location
   __ mov(edi, Operand(esp, eax, times_pointer_size, 3 * kPointerSize));
   __ mov(Operand(esp, 2 * kPointerSize), edi);
 
-  // Slot meant for receiver contains return address. Reset it so that
-  // we will not incorrectly interpret return address as an object.
-  __ mov(Operand(esp, eax, times_pointer_size, 3 * kPointerSize), Immediate(0));
-
   // Step 5 copy arguments to correct locations.
-  __ mov(edx, eax);
+  if (is_receiver_available) {

[rmcilroy, 2016/09/06 10:59:35]

ditto (if possible)

[mythria, 2016/09/07 08:59:45]

This is difficult. We do not have any free registers, and we cannot push
receiver before we pop return address. So I left it as is.

+    __ mov(edx, eax);
+    __ add(edx, Immediate(1));
+  } else {
+    // Slot meant for receiver contains return address. Reset it so that
+    // we will not incorrectly interpret return address as an object.
+    __ mov(Operand(esp, eax, times_pointer_size, 3 * kPointerSize),
+           Immediate(0));
+    __ mov(edx, eax);
+  }
 
   Label loop_header, loop_check;
   __ jmp(&loop_check);
   __ bind(&loop_header);
   __ mov(edi, Operand(ecx, 0));
   __ mov(Operand(esp, edx, times_pointer_size, 2 * kPointerSize), edi);
   __ sub(ecx, Immediate(kPointerSize));
   __ sub(edx, Immediate(1));
   __ bind(&loop_check);
   __ cmp(edx, Immediate(0));
   __ j(greater, &loop_header, Label::kNear);
 
   // Restore edi and edx.
   __ Pop(edx);
   __ Pop(edi);
+}
+
+}  // end anonymous namespace
+
+// static
+void Builtins::Generate_InterpreterPushArgsAndConstructImpl(
+    MacroAssembler* masm, CallableType construct_type) {
+  // ----------- S t a t e -------------
+  //  -- eax : the number of arguments (not including the receiver)
+  //  -- edx : the new target
+  //  -- edi : the constructor
+  //  -- ebx : allocation site feedback (if available or undefined)
+  //  -- ecx : the address of the first argument to be pushed. Subsequent
+  //           arguments should be consecutive above this, in the same order as
+  //           they are to be pushed onto the stack.
+  // -----------------------------------
+
+  // Push arguments and move return address to the top of stack.
+  Generate_InterpreterPushArgsAndReturnAddress(masm, false);
 
   __ AssertUndefinedOrAllocationSite(ebx);
   if (construct_type == CallableType::kJSFunction) {
     // Tail call to the function-specific construct stub (still in the caller
     // context at this point).
     __ AssertFunction(edi);
 
     __ mov(ecx, FieldOperand(edi, JSFunction::kSharedFunctionInfoOffset));
     __ mov(ecx, FieldOperand(ecx, SharedFunctionInfo::kConstructStubOffset));
     __ lea(ecx, FieldOperand(ecx, Code::kHeaderSize));
     __ jmp(ecx);
   } else {
     DCHECK_EQ(construct_type, CallableType::kAny);
 
     // Call the constructor with unmodified eax, edi, edx values.
     __ Jump(masm->isolate()->builtins()->Construct(), RelocInfo::CODE_TARGET);
   }
 }
 
+// static
+void Builtins::Generate_InterpreterPushArgsAndConstructArray(
+    MacroAssembler* masm) {
+  // ----------- S t a t e -------------
+  //  -- eax : the number of arguments (not including the receiver)
+  //  -- edx : the target to call checked to be Array function.
+  //  -- ebx : the allocation site feedback
+  //  -- ecx : the address of the first argument to be pushed. Subsequent
+  //           arguments should be consecutive above this, in the same order as
+  //           they are to be pushed onto the stack.
+  // -----------------------------------
+
+  // Push arguments and move return address to the top of stack.
+  Generate_InterpreterPushArgsAndReturnAddress(masm, true);
+
+  // Array constructor expects constructor in edi. It is same as edx here.
+  __ Move(edi, edx);
+
+  ArrayConstructorStub stub(masm->isolate());
+  __ TailCallStub(&stub);
+}
+
 void Builtins::Generate_InterpreterEnterBytecodeDispatch(MacroAssembler* masm) {
   // Set the return address to the correct point in the interpreter entry
   // trampoline.
   Smi* interpreter_entry_return_pc_offset(
       masm->isolate()->heap()->interpreter_entry_return_pc_offset());
   DCHECK_NE(interpreter_entry_return_pc_offset, Smi::FromInt(0));
   __ LoadHeapObject(ebx,
                     masm->isolate()->builtins()->InterpreterEntryTrampoline());
   __ add(ebx, Immediate(interpreter_entry_return_pc_offset->value() +
                         Code::kHeaderSize - kHeapObjectTag));
@@ skipping 2231 matching lines @@
 
 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) {
   Generate_OnStackReplacementHelper(masm, true);
 }
 
 #undef __
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_IA32