Issue 2307883002: Fix type masks for js-interop types.

Issue 2307883002: Fix type masks for js-interop types. (Closed)

Created:
4 years, 3 months ago by Johnni Winther

Modified:
4 years, 3 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix type masks for js-interop types. Type-masks for js-interop types are replaced by `subtype/subclass of JavaScriptObject`. Closes #24822 R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/b358d062c26c18d26d3168898eeb0cf3cfc9cb38

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -7 lines)			Patch
M	pkg/compiler/lib/src/common/resolution.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/no_such_method_registry.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/class_members.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/world.dart	View		4 chunks	+8 lines, -1 line	0 comments	Download
A	tests/compiler/dart2js/jsinterop/abstract_test.dart	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
A	tests/html/js_typed_interop_type1_test.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download
A	tests/html/js_typed_interop_type2_test.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download
A	tests/html/js_typed_interop_type3_test.dart	View		1 chunk	+87 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Johnni Winther

4 years, 3 months ago (2016-09-07 08:43:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
b358d062c26c18d26d3168898eeb0cf3cfc9cb38 (presubmit successful).