Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 from page_sets.system_health import system_health_story | |
| 6 | |
| 7 | |
| 8 class _BlankStory(system_health_story.SystemHealthStory): | |
|
petrcermak
2016/09/08 11:33:17
There's no point in splitting the story into two c
mikecase (-- gone --)
2016/09/08 16:51:49
Done
| |
| 9 """Abstract base class for blank page stories.""" | |
| 10 ABSTRACT_STORY = True | |
| 11 | |
| 12 def _DidLoadDocument(self, action_runner): | |
| 13 # Request a RAF and wait for it to be processed to ensure that the metric | |
|
petrcermak
2016/09/08 11:33:17
I don't think you need this. The stories wait for
mikecase (-- gone --)
2016/09/08 16:51:49
Ack
| |
| 14 # Startup.FirstWebContents.NonEmptyPaint2 is recorded. | |
| 15 action_runner.ExecuteJavaScript( | |
| 16 """ | |
|
petrcermak
2016/09/08 11:33:17
If you do want to keep this code, than:
* s/hasRu
mikecase (-- gone --)
2016/09/08 16:51:49
Done, Done, Done, Done, Done
| |
| 17 this.hasRunRAF = 0; | |
| 18 requestAnimationFrame(function() { | |
| 19 this.hasRunRAF = 1; | |
| 20 }); | |
| 21 """ | |
| 22 ) | |
| 23 action_runner.WaitForJavaScriptCondition("this.hasRunRAF == 1") | |
| 24 | |
| 25 | |
| 26 class BlankStoryAboutBlank(_BlankStory): | |
|
petrcermak
2016/09/08 11:33:17
nit: BlankAboutBlankStory (the last word should be
mikecase (-- gone --)
2016/09/08 16:51:49
Done
| |
| 27 NAME = 'blank:about:blank' | |
| 28 URL = 'about:blank' | |
| OLD | NEW |