Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2307873002: Fix more-specific for interface types with call functions. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix more-specific for interface types with call functions. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/a47c6a240c5eabc82a3d1612d66e899d34a85128

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M pkg/compiler/lib/src/dart_types.dart View 4 chunks +20 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 1 chunk +6 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 3 months ago (2016-09-02 12:50:44 UTC) #2
ahe
lgtm https://codereview.chromium.org/2307873002/diff/1/tests/compiler/dart2js/subtype_test.dart File tests/compiler/dart2js/subtype_test.dart (right): https://codereview.chromium.org/2307873002/diff/1/tests/compiler/dart2js/subtype_test.dart#newcode287 tests/compiler/dart2js/subtype_test.dart:287: expect(true, A, function); I'm not sure this is ...
4 years, 3 months ago (2016-09-02 13:07:11 UTC) #3
Johnni Winther
https://codereview.chromium.org/2307873002/diff/1/tests/compiler/dart2js/subtype_test.dart File tests/compiler/dart2js/subtype_test.dart (right): https://codereview.chromium.org/2307873002/diff/1/tests/compiler/dart2js/subtype_test.dart#newcode287 tests/compiler/dart2js/subtype_test.dart:287: expect(true, A, function); On 2016/09/02 13:07:11, ahe wrote: > ...
4 years, 3 months ago (2016-09-02 13:12:37 UTC) #4
Johnni Winther
4 years, 3 months ago (2016-09-05 08:00:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a47c6a240c5eabc82a3d1612d66e899d34a85128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698