Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2307863002: [turbofan] Add liveness analysis to the BytecodeGraphBuilder. (Closed)

Created:
4 years, 3 months ago by epertoso
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add liveness analysis to the BytecodeGraphBuilder. This is analogous to the variable liveness analysis we do in the AstGraphBuilder, but on the bytecode registers. BUG= Committed: https://crrev.com/65128ab23050ee545b1b5c010afd84fa778f002a Cr-Commit-Position: refs/heads/master@{#39248}

Patch Set 1 #

Patch Set 2 : Fix a verification method. #

Patch Set 3 : Rebaselined. #

Patch Set 4 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -30 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 2 4 chunks +19 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 20 chunks +131 lines, -25 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
epertoso
4 years, 3 months ago (2016-09-02 12:34:26 UTC) #5
Benedikt Meurer
LGTM, thanks.
4 years, 3 months ago (2016-09-02 12:39:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863002/40001
4 years, 3 months ago (2016-09-07 11:59:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12300) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-07 12:16:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863002/60001
4 years, 3 months ago (2016-09-07 12:36:30 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-07 13:00:08 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 13:00:33 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/65128ab23050ee545b1b5c010afd84fa778f002a
Cr-Commit-Position: refs/heads/master@{#39248}

Powered by Google App Engine
This is Rietveld 408576698