Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2307843002:
views: use theme colors for TabbedPane (Closed)
|
Created:
4 years, 3 months ago by Elly Fong-Jones Modified:
4 years, 3 months ago CC:
chromium-reviews, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionviews: use theme colors for TabbedPane
BUG=
Committed: https://crrev.com/0c9c96a5d10e4fd47e2e0911d5f45081322532ec
Cr-Commit-Position: refs/heads/master@{#416901}
Patch Set 1 #
Total comments: 1
Patch Set 2 : move ternary #Messages
Total messages: 18 (9 generated)
Description was changed from ========== views: use theme colors for TabbedPane BUG= ========== to ========== views: use theme colors for TabbedPane BUG= ==========
ellyjones@chromium.org changed reviewers: + estade@chromium.org
estade: ptal? :)
lgtm https://codereview.chromium.org/2307843002/diff/1/ui/views/controls/tabbed_pa... File ui/views/controls/tabbed_pane/tabbed_pane.cc (right): https://codereview.chromium.org/2307843002/diff/1/ui/views/controls/tabbed_pa... ui/views/controls/tabbed_pane/tabbed_pane.cc:267: ? theme->GetSystemColor(ui::NativeTheme::kColorId_FocusedBorderColor) nit: move ternary inside GetSystemColor
The CQ bit was checked by ellyjones@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org Link to the patchset: https://codereview.chromium.org/2307843002/#ps20001 (title: "move ternary")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
ellyjones@chromium.org changed reviewers: + sky@chromium.org
sky: ptal? :)
LGTM
The CQ bit was checked by ellyjones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== views: use theme colors for TabbedPane BUG= ========== to ========== views: use theme colors for TabbedPane BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== views: use theme colors for TabbedPane BUG= ========== to ========== views: use theme colors for TabbedPane BUG= Committed: https://crrev.com/0c9c96a5d10e4fd47e2e0911d5f45081322532ec Cr-Commit-Position: refs/heads/master@{#416901} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0c9c96a5d10e4fd47e2e0911d5f45081322532ec Cr-Commit-Position: refs/heads/master@{#416901} |
