Issue 2307813002: Disable CrashWhenSubprocessWithoutArgumentFilter test

Issue 2307813002: Disable CrashWhenSubprocessWithoutArgumentFilter test (Closed)

Created:
4 years, 3 months ago by magjed_chromium

Modified:
4 years, 3 months ago

Reviewers:
oystein (OOO til 10th of July)

CC:
chromium-reviews, tracing+reviews_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org, Matt Giuca, Fady Samuel, ccameron

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable CrashWhenSubprocessWithoutArgumentFilter test The test is flaky. It fails with: [ RUN ] BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter [5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed: !argument_filter_predicate_.is_null(). Backtrace: base::debug::StackTrace::StackTrace [0x02022B17+23] logging::LogMessage::~LogMessage [0x01FCA911+49] base::trace_event::TraceLog::FinishFlush [0x01FF104F+255] base::internal::Invoker<base::internal::BindState<void (__thiscall base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void __cdecl(void)>::Run [0x01FF2B06+22] base::debug::TaskAnnotator::RunTask [0x0203EF90+256] base::MessageLoop::RunTask [0x01FE101B+1211] base::MessageLoop::DoWork [0x01FE034E+606] base::MessagePumpForIO::DoRunLoop [0x02033FBC+188] base::MessagePumpWin::Run [0x02034DCA+74] base::MessageLoop::RunHandler [0x01FE0B57+103] base::RunLoop::Run [0x01FDCEA9+41] base::Thread::Run [0x020133AC+92] base::Thread::ThreadMain [0x02013D55+469] base::PlatformThread::Sleep [0x01FDE9C2+290] BaseThreadInitThunk [0x7693338A+18] RtlInitializeExceptionChain [0x772B9F72+99] RtlInitializeExceptionChain [0x772B9F45+54] TBR=oysteine@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromium:639706, chromium:639706 Committed: https://crrev.com/12555044cc96932286e795bb28688c1d4c8a50ee Cr-Commit-Position: refs/heads/master@{#416229}

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	content/browser/tracing/background_tracing_manager_browsertest.cc	View		1 chunk	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 12 (9 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

magjed_chromium

Description was changed from ========== Disable CrashWhenSubprocessWithoutArgumentFilter test The test is flaky. TBR=oysteine@chromium.org NOTREECHECKS=true NOTRY=true ...

4 years, 3 months ago (2016-09-02 10:03:18 UTC) #5

magjed_chromium

Description was changed from ========== Disable CrashWhenSubprocessWithoutArgumentFilter test The test is flaky. It fails with: ...

4 years, 3 months ago (2016-09-02 10:03:30 UTC) #6

Description was changed from

==========
Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ]
BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter

[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed:
!argument_filter_predicate_.is_null(). 

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall
base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void
__cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706
==========

to

==========
Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ]
BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed:
!argument_filter_predicate_.is_null(). 

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall
base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void
__cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706
==========

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307813002/1

4 years, 3 months ago (2016-09-02 10:04:07 UTC) #8

commit-bot: I haz the power

Description was changed from ========== Disable CrashWhenSubprocessWithoutArgumentFilter test The test is flaky. It fails with: ...

4 years, 3 months ago (2016-09-02 10:07:25 UTC) #9

Message was sent while issue was closed.

Description was changed from

==========
Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ]
BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed:
!argument_filter_predicate_.is_null(). 

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall
base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void
__cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706
==========

to

==========
Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ]
BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed:
!argument_filter_predicate_.is_null(). 

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall
base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void
__cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706
==========

commit-bot: I haz the power

Description was changed from ========== Disable CrashWhenSubprocessWithoutArgumentFilter test The test is flaky. It fails with: ...

4 years, 3 months ago (2016-09-02 10:09:30 UTC) #11

Message was sent while issue was closed.

Description was changed from

==========
Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ]
BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed:
!argument_filter_predicate_.is_null(). 

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall
base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void
__cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706
==========

to

==========
Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ]
BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed:
!argument_filter_predicate_.is_null().

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall
base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void
__cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639706, chromium:639706

Committed: https://crrev.com/12555044cc96932286e795bb28688c1d4c8a50ee
Cr-Commit-Position: refs/heads/master@{#416229}
==========

commit-bot: I haz the power

4 years, 3 months ago (2016-09-02 10:09:31 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/12555044cc96932286e795bb28688c1d4c8a50ee
Cr-Commit-Position: refs/heads/master@{#416229}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages