Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: scripts/slave/upload_goma_logs.py

Issue 2307743002: Reland "Avoid to use environment." (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/upload_goma_logs.py
diff --git a/scripts/slave/upload_goma_logs.py b/scripts/slave/upload_goma_logs.py
index b6817b64a3c149bcebe9d75b60462a1762a7d22a..30501a6b526e54bcb6e6a6210558681027090388 100644
--- a/scripts/slave/upload_goma_logs.py
+++ b/scripts/slave/upload_goma_logs.py
@@ -55,10 +55,13 @@ def main():
# Arguments set to os.environ
parser.add_argument('--buildbot-buildername',
+ default='unknown',
help='buildbot buildername')
parser.add_argument('--buildbot-mastername',
+ default='unknown',
help='buildbot mastername')
parser.add_argument('--buildbot-slavename',
+ default='unknown',
help='buildbot slavename')
parser.add_argument('--buildbot-clobber',
help='buildbot clobber')
@@ -94,7 +97,11 @@ def main():
# error in parse_args() using required option.
assert args.json_status is not None and os.path.exists(args.json_status)
assert args.ninja_log_exit_status is not None
- goma_utils.SendGomaTsMon(args.json_status, args.ninja_log_exit_status)
+ goma_utils.SendGomaTsMon(args.json_status, args.ninja_log_exit_status,
+ builder=args.buildbot_buildername,
+ master=args.buildbot_mastername,
+ slave=args.buildbot_slavename,
+ clobber=args.buildbot_clobber)
return 0

Powered by Google App Engine
This is Rietveld 408576698