WebShare: Fixed the API occasionally breaking on a particular page.

WebShare: Fixed the API occasionally breaking on a particular page.

On Android, the WebShare Mojo pipe would occasionally be closed due to
the Java service dropping a callback without calling it. Now always
calls the callback.

Also partially fixes crbug.com/636274; previously the navigator.share
promise would not be rejected if the user cancels the picker. Now it is
rejected (though not immediately). This needs to be fixed better but at
least the promise will (eventually) be resolved or rejected.

BUG=640324, 636274
Committed: https://crrev.com/06be389804f232f4e992be8e95b24322a1062ebb
Cr-Commit-Position: refs/heads/master@{#416862}

[Matt Giuca, 2016-09-02 06:51:42]

mgiuca@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2016-09-02 18:16:49]

lgtm % comment

https://codereview.chromium.org/2307733003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/2307733003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:123:
private boolean mTargetChosen = false;
Do we need this boolean or can we just rely on the sLastRegisteredReceiver being
null or not?

[Matt Giuca, 2016-09-05 01:02:04]

Done. Will wait for you to quickly inspect the new version.

https://codereview.chromium.org/2307733003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/2307733003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:123:
private boolean mTargetChosen = false;
On 2016/09/02 18:16:49, David Trainor wrote:
> Do we need this boolean or can we just rely on the sLastRegisteredReceiver
being
> null or not?

Yeah good point; the existing code that sets and checks sLastRegisteredReceiver
= null means that sLastRegisteredReceiver.mTargetChosen will always be false, so
there is no point having it.

[David Trainor- moved to gerrit, 2016-09-07 05:13:07]

lgtm!

[Matt Giuca, 2016-09-07 05:30:38]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-09-07 05:30:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 06:18:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-07 06:20:17]

Description was changed from

==========
WebShare: Fixed the API occasionally breaking on a particular page.

On Android, the WebShare Mojo pipe would occasionally be closed due to
the Java service dropping a callback without calling it. Now always
calls the callback.

Also partially fixes crbug.com/636274; previously the navigator.share
promise would not be rejected if the user cancels the picker. Now it is
rejected (though not immediately). This needs to be fixed better but at
least the promise will (eventually) be resolved or rejected.

BUG=640324,636274
==========

to

==========
WebShare: Fixed the API occasionally breaking on a particular page.

On Android, the WebShare Mojo pipe would occasionally be closed due to
the Java service dropping a callback without calling it. Now always
calls the callback.

Also partially fixes crbug.com/636274; previously the navigator.share
promise would not be rejected if the user cancels the picker. Now it is
rejected (though not immediately). This needs to be fixed better but at
least the promise will (eventually) be resolved or rejected.

BUG=640324,636274

Committed: https://crrev.com/06be389804f232f4e992be8e95b24322a1062ebb
Cr-Commit-Position: refs/heads/master@{#416862}
==========

[commit-bot: I haz the power, 2016-09-07 06:20:18]

Patchset 4 (id:??) landed as
https://crrev.com/06be389804f232f4e992be8e95b24322a1062ebb
Cr-Commit-Position: refs/heads/master@{#416862}