Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/devtools/android_device.cc

Issue 230773003: DevTools: do not retain android_usb_devices in their manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments addressed. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/devtools/adb/android_usb_socket.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/android_device.h" 5 #include "chrome/browser/devtools/android_device.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/threading/thread.h" 10 #include "base/threading/thread.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 UsbDeviceImpl::UsbDeviceImpl(AndroidUsbDevice* device) 101 UsbDeviceImpl::UsbDeviceImpl(AndroidUsbDevice* device)
102 : Device(device->serial(), device->is_connected()), 102 : Device(device->serial(), device->is_connected()),
103 device_(device) { 103 device_(device) {
104 device_->InitOnCallerThread(); 104 device_->InitOnCallerThread();
105 } 105 }
106 106
107 void UsbDeviceImpl::RunCommand(const std::string& command, 107 void UsbDeviceImpl::RunCommand(const std::string& command,
108 const CommandCallback& callback) { 108 const CommandCallback& callback) {
109 DCHECK(CalledOnValidThread()); 109 DCHECK(CalledOnValidThread());
110 net::StreamSocket* socket = device_->CreateSocket(command); 110 net::StreamSocket* socket = device_->CreateSocket(command);
111 if (!socket) {
112 callback.Run(net::ERR_CONNECTION_FAILED, std::string());
113 return;
114 }
111 int result = socket->Connect(base::Bind(&UsbDeviceImpl::OpenedForCommand, 115 int result = socket->Connect(base::Bind(&UsbDeviceImpl::OpenedForCommand,
112 this, callback, socket)); 116 this, callback, socket));
113 if (result != net::ERR_IO_PENDING) 117 if (result != net::ERR_IO_PENDING)
114 callback.Run(result, std::string()); 118 callback.Run(result, std::string());
115 } 119 }
116 120
117 void UsbDeviceImpl::OpenSocket(const std::string& name, 121 void UsbDeviceImpl::OpenSocket(const std::string& name,
118 const SocketCallback& callback) { 122 const SocketCallback& callback) {
119 DCHECK(CalledOnValidThread()); 123 DCHECK(CalledOnValidThread());
120 std::string socket_name = 124 std::string socket_name =
121 base::StringPrintf(kLocalAbstractCommand, name.c_str()); 125 base::StringPrintf(kLocalAbstractCommand, name.c_str());
122 net::StreamSocket* socket = device_->CreateSocket(socket_name); 126 net::StreamSocket* socket = device_->CreateSocket(socket_name);
127 if (!socket) {
128 callback.Run(net::ERR_CONNECTION_FAILED, NULL);
129 return;
130 }
123 int result = socket->Connect(base::Bind(&UsbDeviceImpl::OnOpenSocket, this, 131 int result = socket->Connect(base::Bind(&UsbDeviceImpl::OnOpenSocket, this,
124 callback, socket)); 132 callback, socket));
125 if (result != net::ERR_IO_PENDING) 133 if (result != net::ERR_IO_PENDING)
126 callback.Run(result, NULL); 134 callback.Run(result, NULL);
127 } 135 }
128 136
129 void UsbDeviceImpl::OnOpenSocket(const SocketCallback& callback, 137 void UsbDeviceImpl::OnOpenSocket(const SocketCallback& callback,
130 net::StreamSocket* socket, 138 net::StreamSocket* socket,
131 int result) { 139 int result) {
132 callback.Run(result, result == net::OK ? socket : NULL); 140 callback.Run(result, result == net::OK ? socket : NULL);
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 } 529 }
522 530
523 AndroidDeviceManager::Device* 531 AndroidDeviceManager::Device*
524 AndroidDeviceManager::FindDevice(const std::string& serial) { 532 AndroidDeviceManager::FindDevice(const std::string& serial) {
525 DCHECK(CalledOnValidThread()); 533 DCHECK(CalledOnValidThread());
526 DeviceMap::const_iterator it = devices_.find(serial); 534 DeviceMap::const_iterator it = devices_.find(serial);
527 if (it == devices_.end()) 535 if (it == devices_.end())
528 return NULL; 536 return NULL;
529 return (*it).second.get(); 537 return (*it).second.get();
530 } 538 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/adb/android_usb_socket.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698