gclient_scm.py - Issue 230773002: SplitUrlRevision when obtaining the cache_dir in gclient_scm.GetActualRemoteURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_scm.py

Issue 230773002: SplitUrlRevision when obtaining the cache_dir in gclient_scm.GetActualRemoteURL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Rebase after https://chromium.googlesource.com/chromium/tools/depot_tools/+/848fd49 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py

index 0de67bd584134be632ae572d9fd6f2da880c83c9..ab07b830dad4d296bf295af53a3b061a37d57d5a 100644

--- a/gclient_scm.py

+++ b/gclient_scm.py

@@ -166,7 +166,8 @@ class SCMWrapper(object):

# If a cache_dir is used, obtain the actual remote URL from the cache.

if getattr(self, 'cache_dir', None):

- mirror = git_cache.Mirror(self.url)

+ url, _ = gclient_utils.SplitUrlRevision(self.url)

+ mirror = git_cache.Mirror(url)

if (mirror.exists() and mirror.mirror_path.replace('\\', '/') ==

actual_remote_url.replace('\\', '/')):

actual_remote_url = shlex.split(self._Capture(

« no previous file with comments | « no previous file | no next file » | no next file with comments »