chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java - Issue 2307713002: [Android] Provide an API for manually triggering a crash report upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

Issue 2307713002: [Android] Provide an API for manually triggering a crash report upload. (Closed)

Patch Set: More test suppressions Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

index 15fb25a7097bce3f1a93b2b3593f5eb94a707a90..acfd3a0947cddb2c955791caca5a11ea6f7b914f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

@@ -96,7 +96,7 @@ public class MinidumpUploadCallable implements Callable<Integer> {

if (mPermManager.isUploadEnabledForTests()) {

Log.i(TAG, "Minidump upload enabled for tests, skipping other checks.");

- } else {

+ } else if (!CrashFileManager.isForcedUpload(mFileToUpload)) {

if (!mPermManager.isUploadUserPermitted()) {

Log.i(TAG, "Minidump upload is not permitted by user. Marking file as skipped for "

+ "cleanup to prevent future uploads.");