Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2307673002: Remove dead code for writing ICData entries. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -46 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/object_service.cc View 2 chunks +2 lines, -39 lines 0 comments Download
M runtime/vm/source_report.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 3 months ago (2016-09-01 22:23:45 UTC) #2
cbernaschina
On 2016/09/01 22:23:45, rmacnak wrote: LGTM
4 years, 3 months ago (2016-09-01 22:25:55 UTC) #3
rmacnak
4 years, 3 months ago (2016-09-01 22:58:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f2ea64b1368f1955f597e8880a0fb80a805b488 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698