Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Side by Side Diff: components/search_engines/default_search_manager_unittest.cc

Issue 2307663002: Remove ScopedVector from search_engines. (Closed)
Patch Set: devlin Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/search_engines/default_search_manager.h" 5 #include "components/search_engines/default_search_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 manager.SetUserSelectedDefaultSearchEngine(data); 185 manager.SetUserSelectedDefaultSearchEngine(data);
186 TemplateURLData* read_data = manager.GetDefaultSearchEngine(NULL); 186 TemplateURLData* read_data = manager.GetDefaultSearchEngine(NULL);
187 ExpectSimilar(&data, read_data); 187 ExpectSimilar(&data, read_data);
188 } 188 }
189 189
190 // Test DefaultSearchmanager handles user-selected DSEs correctly. 190 // Test DefaultSearchmanager handles user-selected DSEs correctly.
191 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByUserPref) { 191 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByUserPref) {
192 size_t default_search_index = 0; 192 size_t default_search_index = 0;
193 DefaultSearchManager manager(pref_service(), 193 DefaultSearchManager manager(pref_service(),
194 DefaultSearchManager::ObserverCallback()); 194 DefaultSearchManager::ObserverCallback());
195 ScopedVector<TemplateURLData> prepopulated_urls = 195 std::vector<std::unique_ptr<TemplateURLData>> prepopulated_urls =
196 TemplateURLPrepopulateData::GetPrepopulatedEngines(pref_service(), 196 TemplateURLPrepopulateData::GetPrepopulatedEngines(pref_service(),
197 &default_search_index); 197 &default_search_index);
198 DefaultSearchManager::Source source = DefaultSearchManager::FROM_POLICY; 198 DefaultSearchManager::Source source = DefaultSearchManager::FROM_POLICY;
199 // If no user pref is set, we should use the pre-populated values. 199 // If no user pref is set, we should use the pre-populated values.
200 ExpectSimilar(prepopulated_urls[default_search_index], 200 ExpectSimilar(prepopulated_urls[default_search_index].get(),
201 manager.GetDefaultSearchEngine(&source)); 201 manager.GetDefaultSearchEngine(&source));
202 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source); 202 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
203 203
204 // Setting a user pref overrides the pre-populated values. 204 // Setting a user pref overrides the pre-populated values.
205 std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user"); 205 std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user");
206 manager.SetUserSelectedDefaultSearchEngine(*data.get()); 206 manager.SetUserSelectedDefaultSearchEngine(*data.get());
207 207
208 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source)); 208 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source));
209 EXPECT_EQ(DefaultSearchManager::FROM_USER, source); 209 EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
210 210
211 // Updating the user pref (externally to this instance of 211 // Updating the user pref (externally to this instance of
212 // DefaultSearchManager) triggers an update. 212 // DefaultSearchManager) triggers an update.
213 std::unique_ptr<TemplateURLData> new_data = 213 std::unique_ptr<TemplateURLData> new_data =
214 GenerateDummyTemplateURLData("user2"); 214 GenerateDummyTemplateURLData("user2");
215 DefaultSearchManager other_manager(pref_service(), 215 DefaultSearchManager other_manager(pref_service(),
216 DefaultSearchManager::ObserverCallback()); 216 DefaultSearchManager::ObserverCallback());
217 other_manager.SetUserSelectedDefaultSearchEngine(*new_data.get()); 217 other_manager.SetUserSelectedDefaultSearchEngine(*new_data.get());
218 218
219 ExpectSimilar(new_data.get(), manager.GetDefaultSearchEngine(&source)); 219 ExpectSimilar(new_data.get(), manager.GetDefaultSearchEngine(&source));
220 EXPECT_EQ(DefaultSearchManager::FROM_USER, source); 220 EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
221 221
222 // Clearing the user pref should cause the default search to revert to the 222 // Clearing the user pref should cause the default search to revert to the
223 // prepopulated vlaues. 223 // prepopulated vlaues.
224 manager.ClearUserSelectedDefaultSearchEngine(); 224 manager.ClearUserSelectedDefaultSearchEngine();
225 ExpectSimilar(prepopulated_urls[default_search_index], 225 ExpectSimilar(prepopulated_urls[default_search_index].get(),
226 manager.GetDefaultSearchEngine(&source)); 226 manager.GetDefaultSearchEngine(&source));
227 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source); 227 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
228 } 228 }
229 229
230 // Test that DefaultSearch manager detects changes to kSearchProviderOverrides. 230 // Test that DefaultSearch manager detects changes to kSearchProviderOverrides.
231 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByOverrides) { 231 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByOverrides) {
232 SetOverrides(pref_service(), false); 232 SetOverrides(pref_service(), false);
233 size_t default_search_index = 0; 233 size_t default_search_index = 0;
234 DefaultSearchManager manager(pref_service(), 234 DefaultSearchManager manager(pref_service(),
235 DefaultSearchManager::ObserverCallback()); 235 DefaultSearchManager::ObserverCallback());
236 ScopedVector<TemplateURLData> prepopulated_urls = 236 std::vector<std::unique_ptr<TemplateURLData>> prepopulated_urls =
237 TemplateURLPrepopulateData::GetPrepopulatedEngines(pref_service(), 237 TemplateURLPrepopulateData::GetPrepopulatedEngines(pref_service(),
238 &default_search_index); 238 &default_search_index);
239 239
240 DefaultSearchManager::Source source = DefaultSearchManager::FROM_POLICY; 240 DefaultSearchManager::Source source = DefaultSearchManager::FROM_POLICY;
241 TemplateURLData first_default(*manager.GetDefaultSearchEngine(&source)); 241 TemplateURLData first_default(*manager.GetDefaultSearchEngine(&source));
242 ExpectSimilar(prepopulated_urls[default_search_index], &first_default); 242 ExpectSimilar(prepopulated_urls[default_search_index].get(), &first_default);
243 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source); 243 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
244 244
245 // Update the overrides: 245 // Update the overrides:
246 SetOverrides(pref_service(), true); 246 SetOverrides(pref_service(), true);
247 prepopulated_urls = TemplateURLPrepopulateData::GetPrepopulatedEngines( 247 prepopulated_urls = TemplateURLPrepopulateData::GetPrepopulatedEngines(
248 pref_service(), &default_search_index); 248 pref_service(), &default_search_index);
249 249
250 // Make sure DefaultSearchManager updated: 250 // Make sure DefaultSearchManager updated:
251 ExpectSimilar(prepopulated_urls[default_search_index], 251 ExpectSimilar(prepopulated_urls[default_search_index].get(),
252 manager.GetDefaultSearchEngine(&source)); 252 manager.GetDefaultSearchEngine(&source));
253 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source); 253 EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
254 EXPECT_NE(manager.GetDefaultSearchEngine(NULL)->short_name(), 254 EXPECT_NE(manager.GetDefaultSearchEngine(NULL)->short_name(),
255 first_default.short_name()); 255 first_default.short_name());
256 EXPECT_NE(manager.GetDefaultSearchEngine(NULL)->keyword(), 256 EXPECT_NE(manager.GetDefaultSearchEngine(NULL)->keyword(),
257 first_default.keyword()); 257 first_default.keyword());
258 } 258 }
259 259
260 // Test DefaultSearchManager handles policy-enforced DSEs correctly. 260 // Test DefaultSearchManager handles policy-enforced DSEs correctly.
261 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByPolicy) { 261 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByPolicy) {
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 ExpectSimilar(extension_data_3.get(), 325 ExpectSimilar(extension_data_3.get(),
326 manager.GetDefaultSearchEngine(&source)); 326 manager.GetDefaultSearchEngine(&source));
327 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source); 327 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
328 328
329 manager.ClearExtensionControlledDefaultSearchEngine(); 329 manager.ClearExtensionControlledDefaultSearchEngine();
330 330
331 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source)); 331 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source));
332 EXPECT_EQ(DefaultSearchManager::FROM_USER, source); 332 EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
333 } 333 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698