Account for the fact that some type traits have static methods.

Handle type traits with 1) static methods or 2) enum type.

BUG=640749
Committed: https://crrev.com/c6a6c934a3c611b004f00290fab85a0b08f5887e
Cr-Commit-Position: refs/heads/master@{#416331}

[Łukasz Anforowicz, 2016-09-01 20:11:48]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-09-01 20:11:49]

Daniel, can you take a look please?  Just one small tweak in
|is_type_trait_value| matcher.

[dcheng, 2016-09-01 21:04:22]

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:651:
recordDecl(has(cxxMethodDecl(isUserProvidedInstanceMethod()))))));
Might be slightly nicer to compose the isUserProvided() matcher with a custom
isInstanceMethod() matcher.

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc (right):

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc:96: template
<typename T, typename U>
Please add some comments to this test (e.g. what should be rewritten, what
shouldn't be rewritten)

[Łukasz Anforowicz, 2016-09-01 21:39:45]

Daniel, can you take another look please?

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:651:
recordDecl(has(cxxMethodDecl(isUserProvidedInstanceMethod()))))));
On 2016/09/01 21:04:21, dcheng wrote:
> Might be slightly nicer to compose the isUserProvided() matcher with a custom
> isInstanceMethod() matcher.

Done.  Also - it turns out that isUserProvided is an already existing, built-in
matcher :->

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc (right):

https://codereview.chromium.org/2307643002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc:96: template
<typename T, typename U>
On 2016/09/01 21:04:22, dcheng wrote:
> Please add some comments to this test (e.g. what should be rewritten, what
> shouldn't be rewritten)

Done.

[Łukasz Anforowicz, 2016-09-02 18:43:18]

Description was changed from

==========
Account for the fact that some type traits have static methods.

BUG=640749
==========

to

==========
Handle type traits with 1) static methods or 2) enum type.

BUG=640749
==========

[Łukasz Anforowicz, 2016-09-02 18:43:56]

Just a heads-up that I added one more tweak in patchset #3 to account for one
more corner-case I've just discovered.

[dcheng, 2016-09-02 19:05:22]

lgtm

[dcheng, 2016-09-02 19:05:44]

lgtm

[Łukasz Anforowicz, 2016-09-02 19:17:06]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-09-02 19:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 20:18:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 20:20:57]

Description was changed from

==========
Handle type traits with 1) static methods or 2) enum type.

BUG=640749
==========

to

==========
Handle type traits with 1) static methods or 2) enum type.

BUG=640749

Committed: https://crrev.com/c6a6c934a3c611b004f00290fab85a0b08f5887e
Cr-Commit-Position: refs/heads/master@{#416331}
==========

[commit-bot: I haz the power, 2016-09-02 20:20:58]

Patchset 3 (id:??) landed as
https://crrev.com/c6a6c934a3c611b004f00290fab85a0b08f5887e
Cr-Commit-Position: refs/heads/master@{#416331}