[MacViews] Fix Drag and Drop bugs

[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=599585
Committed: https://crrev.com/05fd4c1a2fcbd2cb6ef5b5eceffa8e2f09579a35
Cr-Commit-Position: refs/heads/master@{#416419}

[spqchan, 2016-09-01 19:19:36]

Description was changed from

==========
[MacViews] Fix Drag and Drop bugs

BUG=
==========

to

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=
==========

[spqchan, 2016-09-01 19:20:44]

Description was changed from

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=
==========

to

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=599585
==========

[spqchan, 2016-09-01 19:21:32]

spqchan@chromium.org changed reviewers:
+ thakis@chromium.org

[spqchan, 2016-09-01 19:21:32]

PTAL

[Nico, 2016-09-01 21:52:42]

ui/base lgtm, but an ui/views/cocoa/OWNERS should probably look at the change
there

[spqchan, 2016-09-01 21:55:29]

spqchan@chromium.org changed reviewers:
+ sky@chromium.org

[spqchan, 2016-09-01 21:55:29]

Thanks!

+sky for ui/views OWNER

[Nico, 2016-09-01 21:58:06]

ui/views/cocoa/OWNERS, not ui/views/OWNERS :-P

On Thu, Sep 1, 2016 at 5:55 PM, <spqchan@chromium.org> wrote:

> Thanks!
>
> +sky for ui/views OWNER
>
> https://codereview.chromium.org/2307633002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spqchan, 2016-09-01 22:01:59]

Ah...unfortunately tapted is OOO until Sept 15 so I don't think there's anyone
else.

[sky, 2016-09-01 23:03:52]

https://codereview.chromium.org/2307633002/diff/1/ui/views/cocoa/drag_drop_cl...
File ui/views/cocoa/drag_drop_client_mac.mm (right):

https://codereview.chromium.org/2307633002/diff/1/ui/views/cocoa/drag_drop_cl...
ui/views/cocoa/drag_drop_client_mac.mm:154: data_source_.reset();
Is EndDrag() only called if Drop() isn't?

[spqchan, 2016-09-01 23:10:30]

On 2016/09/01 23:03:52, sky wrote:
>
https://codereview.chromium.org/2307633002/diff/1/ui/views/cocoa/drag_drop_cl...
> File ui/views/cocoa/drag_drop_client_mac.mm (right):
> 
>
https://codereview.chromium.org/2307633002/diff/1/ui/views/cocoa/drag_drop_cl...
> ui/views/cocoa/drag_drop_client_mac.mm:154: data_source_.reset();
> Is EndDrag() only called if Drop() isn't?

No, EndDrag() can be called with Drop(). The only time Drop() is called w/o
EndDrag() is if another application drops their data to Chrome

[sky, 2016-09-01 23:44:29]

Ok, LGTM

[spqchan, 2016-09-01 23:50:43]

On 2016/09/01 23:44:29, sky wrote:
> Ok, LGTM

thanks!

[spqchan, 2016-09-01 23:50:46]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-09-01 23:51:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 01:35:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 01:35:02]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2016-09-02 19:37:01]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-09-02 19:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2307633002/#ps20001
(title: "Fixed test")

[commit-bot: I haz the power, 2016-09-02 19:37:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 20:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:50:27]

Exceeded global retry quota

[spqchan, 2016-09-03 00:47:09]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:51:05]

Description was changed from

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=599585
==========

to

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=599585
==========

[commit-bot: I haz the power, 2016-09-03 00:51:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-03 00:52:41]

Description was changed from

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=599585
==========

to

==========
[MacViews] Fix Drag and Drop bugs

Made changes so that MacViews can accept drops from
other applications.

BUG=599585

Committed: https://crrev.com/05fd4c1a2fcbd2cb6ef5b5eceffa8e2f09579a35
Cr-Commit-Position: refs/heads/master@{#416419}
==========

[commit-bot: I haz the power, 2016-09-03 00:52:42]

Patchset 2 (id:??) landed as
https://crrev.com/05fd4c1a2fcbd2cb6ef5b5eceffa8e2f09579a35
Cr-Commit-Position: refs/heads/master@{#416419}