Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp

Issue 2307623002: [SPv2] Defer decision of raster invalidation after paint for changes z-index, transform, etc. (Closed)
Patch Set: x Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
index 90a189d7d8050147aa9ba12b317d552bb8813b92..f777224e8f7630d37782166adb5067af7ce5dcd2 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
@@ -194,9 +194,6 @@ WTF::String DisplayItem::typeAsDebugString(Type type)
if (isEndClipType(type))
return "End" + clipTypeAsDebugString(endClipTypeToClipType(type));
- if (type == kUninitializedType)
- return "UninitializedType";
-
PAINT_PHASE_BASED_DEBUG_STRINGS(FloatClip);
if (isEndFloatClipType(type))
return "End" + typeAsDebugString(endFloatClipTypeToFloatClipType(type));
@@ -222,6 +219,7 @@ WTF::String DisplayItem::typeAsDebugString(Type type)
DEBUG_STRING_CASE(EndClipPath);
DEBUG_STRING_CASE(Subsequence);
DEBUG_STRING_CASE(EndSubsequence);
+ DEBUG_STRING_CASE(HasBeenMoved);
DEBUG_STRING_CASE(UninitializedType);
DEFAULT_CASE;
}
@@ -238,8 +236,8 @@ WTF::String DisplayItem::asDebugString() const
void DisplayItem::dumpPropertiesAsDebugString(WTF::StringBuilder& stringBuilder) const
{
- if (!hasValidClient()) {
- stringBuilder.append("validClient: false, originalDebugString: ");
+ if (hasBeenMoved()) {
+ stringBuilder.append("movedTo: %zu, originalDebugString: ", movedToIndex());
// This is the original debug string which is in json format.
stringBuilder.append(clientDebugString());
return;

Powered by Google App Engine
This is Rietveld 408576698