Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

Issue 2307623002: [SPv2] Defer decision of raster invalidation after paint for changes z-index, transform, etc. (Closed)
Patch Set: All paint property Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
index c7ecf68b4cf1047b58b55e0c380c628430fdcc0c..95361b6e8a68ed2837ea25c5c4889862c323d715 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
@@ -19,12 +19,12 @@ DisplayItem& DisplayItemList::appendByMoving(DisplayItem& item)
#ifndef NDEBUG
String originalDebugString = item.asDebugString();
#endif
- ASSERT(item.hasValidClient());
- DisplayItem& result = ContiguousContainer::appendByMoving(item, item.derivedSize());
+ DCHECK(!item.hasBeenMoved());
+ DisplayItem& result = ContiguousContainer::appendByMoving(item, item.derivedSize(), size());
// ContiguousContainer::appendByMoving() calls an in-place constructor
- // on item which replaces it with a tombstone/"dead display item" that
- // can be safely destructed but should never be used.
- ASSERT(!item.hasValidClient());
+ // DisplayItem(size_t) to create a placeholder of type HasBeenMoved in
+ // place of the original item.
+ DCHECK(item.hasBeenMoved());
#ifndef NDEBUG
// Save original debug string in the old item to help debugging.
item.setClientDebugString(originalDebugString);

Powered by Google App Engine
This is Rietveld 408576698