Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Issue 2307613002: Remove style checks which require the use of Pass*Ptr in return and parameter types. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
index 07a45c25aa3f511f18222cdbcbb1008bbaf4fddf..f9b59a08870237ee130b5e3b80b167f69455d7d4 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
@@ -3633,26 +3633,6 @@ class PassPtrTest(CppStyleTestBase):
self.assert_pass_ptr_check(
'OwnRefPtr<Type1> myFunction();\n',
'')
- self.assert_pass_ptr_check(
- 'RefPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- 'The return type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]')
- self.assert_pass_ptr_check(
- 'OwnPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- 'The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5]')
- self.assert_pass_ptr_check(
- 'RefPtrWillBeRawPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- 'The return type should use PassRefPtrWillBeRawPtr instead of RefPtrWillBeRawPtr. [readability/pass_ptr] [5]')
- self.assert_pass_ptr_check(
- 'OwnPtrWillBeRawPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- 'The return type should use PassOwnPtrWillBeRawPtr instead of OwnPtrWillBeRawPtr. [readability/pass_ptr] [5]')
def test_ref_ptr_parameter_value(self):
self.assert_pass_ptr_check(
@@ -3661,11 +3641,6 @@ class PassPtrTest(CppStyleTestBase):
'}',
'')
self.assert_pass_ptr_check(
- 'int myFunction(RefPtr<Type1>)\n'
- '{\n'
- '}',
- 'The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]')
- self.assert_pass_ptr_check(
'int myFunction(RefPtr<Type1>&)\n'
'{\n'
'}',
@@ -3703,11 +3678,6 @@ class PassPtrTest(CppStyleTestBase):
'}',
'')
self.assert_pass_ptr_check(
- 'int myFunction(OwnPtr<Type1>)\n'
- '{\n'
- '}',
- 'The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5]')
- self.assert_pass_ptr_check(
'int myFunction(OwnPtr<Type1>& simple)\n'
'{\n'
'}',
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698