Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2246)

Unified Diff: content/renderer/service_worker/embedded_worker_dispatcher.h

Issue 2307543002: ServiceWorker: Mojofication of EWInstance::StopWorker (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/embedded_worker_dispatcher.h
diff --git a/content/renderer/service_worker/embedded_worker_dispatcher.h b/content/renderer/service_worker/embedded_worker_dispatcher.h
index 9c706fa813191cbbf640661c069039200bb189ee..d8387734b3599ad9b29767d63e443681f15cc362 100644
--- a/content/renderer/service_worker/embedded_worker_dispatcher.h
+++ b/content/renderer/service_worker/embedded_worker_dispatcher.h
@@ -67,11 +67,18 @@ class EmbeddedWorkerDispatcher : public IPC::Listener {
ConsoleMessageLevel level,
const std::string& message);
+ // These methods are used by EmbeddedWorkerInstanceClientImpl to keep
+ // consistency between chromium IPC and mojo IPC.
+ // TODO(shimazu): Remove them after all messages for EmbeddedWorker are
+ // replaced by mojo IPC. (Tracking issue: https://crbug.com/629701)
std::unique_ptr<WorkerWrapper> StartWorkerContext(
const EmbeddedWorkerStartParams& params,
std::unique_ptr<ServiceWorkerContextClient> context_client);
void RegisterWorker(int embedded_worker_id,
std::unique_ptr<WorkerWrapper> wrapper);
+ void UnregisterWorker(int embedded_worker_id);
+ // Return false if no worker found
+ bool SetStopWorkerTimer(int embedded_worker_id);
horo 2016/09/13 08:25:33 It doesn't set a timer. RecordStopWorkerTime is b
shimazu 2016/09/20 04:56:20 Done.
IDMap<WorkerWrapper, IDMapOwnPointer> workers_;
std::map<int /* embedded_worker_id */, base::TimeTicks> stop_worker_times_;

Powered by Google App Engine
This is Rietveld 408576698