Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2307543002: ServiceWorker: Mojofication of EWInstance::StopWorker (Closed)
Patch Set: Added a unittest file Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 4efd01bca69345e152c32b5d28ea24e8077500d7..bbb0b982f8f2a227abea46ece45c88492524a639 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -40,6 +40,7 @@
#include "content/renderer/devtools/devtools_agent.h"
#include "content/renderer/render_thread_impl.h"
#include "content/renderer/service_worker/embedded_worker_dispatcher.h"
+#include "content/renderer/service_worker/embedded_worker_instance_client_impl.h"
#include "content/renderer/service_worker/service_worker_type_util.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_message_macros.h"
@@ -221,7 +222,8 @@ ServiceWorkerContextClient::ServiceWorkerContextClient(
int64_t service_worker_version_id,
const GURL& service_worker_scope,
const GURL& script_url,
- int worker_devtools_agent_route_id)
+ int worker_devtools_agent_route_id,
+ std::unique_ptr<EmbeddedWorkerInstanceClientImpl> embedded_worker)
: embedded_worker_id_(embedded_worker_id),
service_worker_version_id_(service_worker_version_id),
service_worker_scope_(service_worker_scope),
@@ -229,7 +231,8 @@ ServiceWorkerContextClient::ServiceWorkerContextClient(
worker_devtools_agent_route_id_(worker_devtools_agent_route_id),
sender_(ChildThreadImpl::current()->thread_safe_sender()),
main_thread_task_runner_(base::ThreadTaskRunnerHandle::Get()),
- proxy_(nullptr) {
+ proxy_(nullptr),
+ embedded_worker_(std::move(embedded_worker)) {
TRACE_EVENT_ASYNC_BEGIN0("ServiceWorker",
"ServiceWorkerContextClient::StartingWorkerContext",
this);
@@ -441,6 +444,15 @@ void ServiceWorkerContextClient::willDestroyWorkerContext(
void ServiceWorkerContextClient::workerContextDestroyed() {
DCHECK(g_worker_client_tls.Pointer()->Get() == NULL);
+ // Check if mojo is enabled
+ if (embedded_worker_) {
+ main_thread_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&EmbeddedWorkerInstanceClientImpl::StopWorkerCompleted,
+ base::Passed(std::move(embedded_worker_))));
+ return;
+ }
+
// Now we should be able to free the WebEmbeddedWorker container on the
// main thread.
main_thread_task_runner_->PostTask(

Powered by Google App Engine
This is Rietveld 408576698