Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 2307543002: ServiceWorker: Mojofication of EWInstance::StopWorker (Closed)
Patch Set: Added a check of the status when detached Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.h
diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h
index eb2ea20844f557782deee41597054ce5c1c74735..fade1fd8d81d4106cd3f2cdeded8095098a4dc2c 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.h
+++ b/content/browser/service_worker/embedded_worker_test_helper.h
@@ -79,15 +79,17 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
static void Bind(const base::WeakPtr<EmbeddedWorkerTestHelper>& helper,
mojom::EmbeddedWorkerInstanceClientRequest request);
- private:
+ protected:
// Implementation of mojo interfaces.
void StartWorker(const EmbeddedWorkerStartParams& params) override;
+ void StopWorker(const StopWorkerCallback& callback) override;
base::WeakPtr<EmbeddedWorkerTestHelper> helper_;
mojo::Binding<mojom::EmbeddedWorkerInstanceClient> binding_;
base::Optional<int> embedded_worker_id_;
+ private:
DISALLOW_COPY_AND_ASSIGN(MockEmbeddedWorkerInstanceClient);
};
@@ -106,6 +108,11 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
// IPC::Listener implementation.
bool OnMessageReceived(const IPC::Message& msg) override;
+ // Register a mojo endpoint object derived from
+ // MockEmbeddedWorkerInstanceClient.
+ void RegisterMockInstanceClient(
+ std::unique_ptr<MockEmbeddedWorkerInstanceClient> client);
+
// IPC sink for EmbeddedWorker messages.
IPC::TestSink* ipc_sink() { return &sink_; }
// Inner IPC sink for script context messages sent via EmbeddedWorker.
@@ -136,6 +143,10 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
TestBrowserContext* browser_context() { return browser_context_.get(); }
+ base::WeakPtr<EmbeddedWorkerTestHelper> AsWeakPtr() {
+ return weak_factory_.GetWeakPtr();
+ }
+
protected:
// Called when StartWorker, StopWorker and SendMessageToWorker message
// is sent to the embedded worker. Override if necessary. By default

Powered by Google App Engine
This is Rietveld 408576698