Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 2307543002: ServiceWorker: Mojofication of EWInstance::StopWorker (Closed)
Patch Set: Added a unittest file Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/service_worker/embedded_worker_dispatcher.h" 5 #include "content/renderer/service_worker/embedded_worker_dispatcher.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "content/child/child_process.h" 12 #include "content/child/child_process.h"
13 #include "content/child/thread_safe_sender.h" 13 #include "content/child/thread_safe_sender.h"
14 #include "content/child/worker_thread_registry.h" 14 #include "content/child/worker_thread_registry.h"
15 #include "content/common/devtools_messages.h" 15 #include "content/common/devtools_messages.h"
16 #include "content/common/service_worker/embedded_worker_messages.h" 16 #include "content/common/service_worker/embedded_worker_messages.h"
17 #include "content/public/common/content_client.h" 17 #include "content/public/common/content_client.h"
18 #include "content/renderer/render_thread_impl.h" 18 #include "content/renderer/render_thread_impl.h"
19 #include "content/renderer/service_worker/embedded_worker_devtools_agent.h" 19 #include "content/renderer/service_worker/embedded_worker_devtools_agent.h"
20 #include "content/renderer/service_worker/embedded_worker_instance_client_impl.h "
20 #include "content/renderer/service_worker/service_worker_context_client.h" 21 #include "content/renderer/service_worker/service_worker_context_client.h"
21 #include "third_party/WebKit/public/platform/WebString.h" 22 #include "third_party/WebKit/public/platform/WebString.h"
22 #include "third_party/WebKit/public/platform/WebURL.h" 23 #include "third_party/WebKit/public/platform/WebURL.h"
23 #include "third_party/WebKit/public/web/WebConsoleMessage.h" 24 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
24 #include "third_party/WebKit/public/web/WebEmbeddedWorker.h" 25 #include "third_party/WebKit/public/web/WebEmbeddedWorker.h"
25 #include "third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h" 26 #include "third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h"
26 27
27 namespace content { 28 namespace content {
28 29
29 EmbeddedWorkerDispatcher::WorkerWrapper::WorkerWrapper( 30 EmbeddedWorkerDispatcher::WorkerWrapper::WorkerWrapper(
(...skipping 19 matching lines...) Expand all
49 OnResumeAfterDownload) 50 OnResumeAfterDownload)
50 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_AddMessageToConsole, 51 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_AddMessageToConsole,
51 OnAddMessageToConsole) 52 OnAddMessageToConsole)
52 IPC_MESSAGE_UNHANDLED(handled = false) 53 IPC_MESSAGE_UNHANDLED(handled = false)
53 IPC_END_MESSAGE_MAP() 54 IPC_END_MESSAGE_MAP()
54 return handled; 55 return handled;
55 } 56 }
56 57
57 void EmbeddedWorkerDispatcher::WorkerContextDestroyed( 58 void EmbeddedWorkerDispatcher::WorkerContextDestroyed(
58 int embedded_worker_id) { 59 int embedded_worker_id) {
59 if (ContainsKey(stop_worker_times_, embedded_worker_id)) { 60 UnregisterWorker(embedded_worker_id);
60 base::TimeTicks stop_time = stop_worker_times_[embedded_worker_id];
61 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.TerminateThread.Time",
62 base::TimeTicks::Now() - stop_time);
63 stop_worker_times_.erase(embedded_worker_id);
64 }
65
66 RenderThreadImpl::current()->thread_safe_sender()->Send( 61 RenderThreadImpl::current()->thread_safe_sender()->Send(
67 new EmbeddedWorkerHostMsg_WorkerStopped(embedded_worker_id)); 62 new EmbeddedWorkerHostMsg_WorkerStopped(embedded_worker_id));
68 workers_.Remove(embedded_worker_id);
69 } 63 }
70 64
71 void EmbeddedWorkerDispatcher::OnStartWorker( 65 void EmbeddedWorkerDispatcher::OnStartWorker(
72 const EmbeddedWorkerMsg_StartWorker_Params& params) { 66 const EmbeddedWorkerMsg_StartWorker_Params& params) {
73 DCHECK(!workers_.Lookup(params.embedded_worker_id)); 67 DCHECK(!workers_.Lookup(params.embedded_worker_id));
74 TRACE_EVENT0("ServiceWorker", "EmbeddedWorkerDispatcher::OnStartWorker"); 68 TRACE_EVENT0("ServiceWorker", "EmbeddedWorkerDispatcher::OnStartWorker");
75 std::unique_ptr<WorkerWrapper> wrapper(new WorkerWrapper( 69 std::unique_ptr<WorkerWrapper> wrapper(new WorkerWrapper(
76 blink::WebEmbeddedWorker::create( 70 blink::WebEmbeddedWorker::create(
77 new ServiceWorkerContextClient(params.embedded_worker_id, 71 new ServiceWorkerContextClient(
78 params.service_worker_version_id, 72 params.embedded_worker_id, params.service_worker_version_id,
79 params.scope, params.script_url, 73 params.scope, params.script_url,
80 params.worker_devtools_agent_route_id), 74 params.worker_devtools_agent_route_id, nullptr),
81 NULL), 75 NULL),
82 params.worker_devtools_agent_route_id)); 76 params.worker_devtools_agent_route_id));
83 77
84 blink::WebEmbeddedWorkerStartData start_data; 78 blink::WebEmbeddedWorkerStartData start_data;
85 start_data.scriptURL = params.script_url; 79 start_data.scriptURL = params.script_url;
86 start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent()); 80 start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent());
87 start_data.waitForDebuggerMode = 81 start_data.waitForDebuggerMode =
88 params.wait_for_debugger ? 82 params.wait_for_debugger ?
89 blink::WebEmbeddedWorkerStartData::WaitForDebugger : 83 blink::WebEmbeddedWorkerStartData::WaitForDebugger :
90 blink::WebEmbeddedWorkerStartData::DontWaitForDebugger; 84 blink::WebEmbeddedWorkerStartData::DontWaitForDebugger;
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 wrapper->worker()->addMessageToConsole(blink::WebConsoleMessage( 146 wrapper->worker()->addMessageToConsole(blink::WebConsoleMessage(
153 target_level, blink::WebString::fromUTF8(message))); 147 target_level, blink::WebString::fromUTF8(message)));
154 } 148 }
155 149
156 void EmbeddedWorkerDispatcher::RegisterWorker( 150 void EmbeddedWorkerDispatcher::RegisterWorker(
157 int embedded_worker_id, 151 int embedded_worker_id,
158 std::unique_ptr<WorkerWrapper> wrapper) { 152 std::unique_ptr<WorkerWrapper> wrapper) {
159 workers_.AddWithID(wrapper.release(), embedded_worker_id); 153 workers_.AddWithID(wrapper.release(), embedded_worker_id);
160 } 154 }
161 155
156 void EmbeddedWorkerDispatcher::UnregisterWorker(int embedded_worker_id) {
157 if (ContainsKey(stop_worker_times_, embedded_worker_id)) {
158 base::TimeTicks stop_time = stop_worker_times_[embedded_worker_id];
159 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.TerminateThread.Time",
160 base::TimeTicks::Now() - stop_time);
161 stop_worker_times_.erase(embedded_worker_id);
162 }
163 workers_.Remove(embedded_worker_id);
164 }
165
166 bool EmbeddedWorkerDispatcher::SetStopWorkerTimer(int embedded_worker_id) {
167 WorkerWrapper* wrapper = workers_.Lookup(embedded_worker_id);
168 if (!wrapper) {
169 LOG(WARNING) << "Got OnStopWorker for nonexistent worker";
170 return false;
171 }
172 // This should eventually call WorkerContextDestroyed. (We may need to post
173 // a delayed task to forcibly abort the worker context if we find it
174 // necessary)
175 stop_worker_times_[embedded_worker_id] = base::TimeTicks::Now();
176 return true;
177 }
178
162 } // namespace content 179 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698