Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 23075028: Get WebRTC resources on Android Testers. (Closed)

Created:
7 years, 3 months ago by kjellander_chromium
Modified:
7 years, 3 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Get WebRTC resources on Android Testers. I know it is a bit ugly to invoke a script in the WebRTC checkout like this to download the resources that are needed for the WebRTC tests, but it's the only way to do this until we've found a better solution that works both when WebRTC is built standalone and as a part of Chrome. I'm working on a better way of downloading the resources in http://review.webrtc.org/2095004/ There's no easy way to include these files into the archive built by zip_build.py since script is made to only include files that are located in the build_dir (e.g. out/Release). BUG=webrtc:1882 TEST=ran a local build. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219774

Patch Set 1 : #

Patch Set 2 : Fixed the path argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build/android/buildbot/bb_host_steps.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kjellander_chromium
This is also needed for https://codereview.chromium.org/17390019/
7 years, 3 months ago (2013-08-27 06:03:14 UTC) #1
Isaac (away)
This is fine. LGTM.
7 years, 3 months ago (2013-08-27 06:16:46 UTC) #2
Isaac (away)
I started an android tryjob; feel free to dcommit or CQ w/ NOTRY=True when after ...
7 years, 3 months ago (2013-08-27 06:19:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/23075028/11001
7 years, 3 months ago (2013-08-27 12:08:41 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-27 12:21:46 UTC) #5
Message was sent while issue was closed.
Change committed as 219774

Powered by Google App Engine
This is Rietveld 408576698