Fixes a crash when copying elements with font-weight lighter or bolder

Fixes a crash when copying elements with font-weight lighter or bolder

While investigating some editing crashes, I noticed an assertion
triggering in EditingStyle due to no treatment over font-weight's
'lighter' and 'bolder' values. This patch fixes this and adds a test to
verify it does not crash when copying/pasting elements using these
values.

BUG=272363
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156188

[esprehn, 2013-08-13 20:07:43]

https://codereview.chromium.org/23075004/diff/1/Source/core/editing/EditingSt...
File Source/core/editing/EditingStyle.cpp (left):

https://codereview.chromium.org/23075004/diff/1/Source/core/editing/EditingSt...
Source/core/editing/EditingStyle.cpp:1520: ASSERT_NOT_REACHED(); // For
CSSValueBolder and CSSValueLighter
Why was this comment here? It seems the author thought this code was unreachable
and those values should never be here.

[eseidel, 2013-08-13 20:11:49]

I suspect the editing code never deals in terms of lighter/bolder but only
specific values, hence the author's presumption.

[leviw_travelin_and_unemployed, 2013-08-13 20:26:28]

This LGTM.

[rniwa-cr, 2013-08-13 20:52:53]

https://codereview.chromium.org/23075004/diff/1/Source/core/editing/EditingSt...
File Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/23075004/diff/1/Source/core/editing/EditingSt...
Source/core/editing/EditingStyle.cpp:1512: case CSSValueBolder:
This is incorrect. e.g. in
<span style="font-weight: 100;">hello <span
style="font-weight:bolder">world</span></span>
"world" is not bolded.

To properly fix this bug, we need to do it in its caller and resolve the used
value through the render tree.

[abinader, 2013-08-13 20:57:57]

On 2013/08/13 20:26:28, Levi wrote:
> This LGTM.

As discussed with Ryosuke on IRC, we need to obtain the computed styles in order
to say whether these are actually bold or not, so I'll get back to work on this
and come up with the proper fix later.

[abinader, 2013-08-14 19:16:57]

Updated patch - avoid removing property if value needs resolving. Adding
resolving code to static function getPropertiesNotIn() seemed too overkill, so
it is not removed from the set so it can be computed on a later step.

[leviw_travelin_and_unemployed, 2013-08-16 01:49:24]

lgtm

[commit-bot: I haz the power, 2013-08-16 01:58:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/23075004/2...

[commit-bot: I haz the power, 2013-08-16 03:29:41]

Change committed as 156188

[rniwa-cr, 2013-08-16 05:56:52]

https://chromiumcodereview.appspot.com/23075004/diff/20001/Source/core/editin...
File Source/core/editing/EditingStyle.cpp (right):

https://chromiumcodereview.appspot.com/23075004/diff/20001/Source/core/editin...
Source/core/editing/EditingStyle.cpp:1545: if
(!fontWeightNeedsResolving(fontWeight.get()) &&
(fontWeightIsBold(fontWeight.get()) == fontWeightIsBold(baseFontWeight.get())))
This is still incorrect. This function MUST remove the property if they're
equal. Not removing it results in incorrect behavior elsewhere.