Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2307433004: Fix chrome crashing in mustash on device. (Closed)

Created:
4 years, 3 months ago by kylechar
Modified:
4 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, James Cook, Peng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome crashing in mustash on device. ChromeDisplayPowerServiceProviderDelegate accesses a nullptr UserActivityDetector. We don't want Chrome to be handling this task in mustash, so don't instantiate the service provider. BUG=643376 Committed: https://crrev.com/237e1315359922b38b4fcf42ad049a55b24d9d85 Cr-Commit-Position: refs/heads/master@{#416085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kylechar
4 years, 3 months ago (2016-09-01 21:09:05 UTC) #2
Daniel Erat
lgtm
4 years, 3 months ago (2016-09-01 21:10:30 UTC) #3
kylechar
Thanks!
4 years, 3 months ago (2016-09-01 21:33:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307433004/1
4 years, 3 months ago (2016-09-01 21:34:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 22:28:08 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 22:30:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/237e1315359922b38b4fcf42ad049a55b24d9d85
Cr-Commit-Position: refs/heads/master@{#416085}

Powered by Google App Engine
This is Rietveld 408576698