Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: tests/standalone/io/http_server_idle_timeout_test.dart

Issue 23074008: Only change timeout to 100ms after the connection is established. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_server_idle_timeout_test.dart
diff --git a/tests/standalone/io/http_server_idle_timeout_test.dart b/tests/standalone/io/http_server_idle_timeout_test.dart
index 91e164c7aacf3d7f75ddec254ba4bd28303a74e5..fbbf0647c006d339b37e8c635d6ab870d31a96a6 100644
--- a/tests/standalone/io/http_server_idle_timeout_test.dart
+++ b/tests/standalone/io/http_server_idle_timeout_test.dart
@@ -7,7 +7,6 @@
// VMOptions=--short_socket_write
// VMOptions=--short_socket_read --short_socket_write
-import "package:expect/expect.dart";
import "dart:async";
import "dart:io";
import "dart:isolate";
@@ -15,11 +14,11 @@ import "dart:isolate";
void testTimeoutAfterRequest() {
HttpServer.bind("127.0.0.1", 0).then((server) {
Søren Gjesse 2013/08/21 07:39:54 Set server.idleTimeout to null here for completene
Anders Johnsen 2013/08/21 07:43:49 Done.
- server.idleTimeout = const Duration(milliseconds: 100);
server.listen((request) => request.response.close());
Socket.connect("127.0.0.1", server.port).then((socket) {
Søren Gjesse 2013/08/21 07:39:54 How about waiting with timer until response data h
Anders Johnsen 2013/08/21 07:43:49 If I wait so long, the timer would already be star
+ server.idleTimeout = const Duration(milliseconds: 100);
var data = "GET / HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
socket.write(data);
socket.listen(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698