Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: components/content_settings/core/browser/website_settings_registry.cc

Issue 2307393002: Stop syncing content settings on Android
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/website_settings_registry.cc
diff --git a/components/content_settings/core/browser/website_settings_registry.cc b/components/content_settings/core/browser/website_settings_registry.cc
index 62ec02addc5670dde9220111e9e1131c1213b4ec..fa0123ffbdbb0f666646dfb1d3cba86ef688e453 100644
--- a/components/content_settings/core/browser/website_settings_registry.cc
+++ b/components/content_settings/core/browser/website_settings_registry.cc
@@ -77,13 +77,16 @@ const WebsiteSettingsInfo* WebsiteSettingsRegistry::Register(
#elif defined(OS_ANDROID)
if (!(platform & PLATFORM_ANDROID))
return nullptr;
+ // Don't sync settings to mobile platforms. The UI is different to desktop and
+ // doesn't allow the settings to be managed in the same way. See
+ // crbug.com/642184.
+ sync_status = WebsiteSettingsInfo::UNSYNCABLE;
#elif defined(OS_IOS)
if (!(platform & PLATFORM_IOS))
return nullptr;
- // Only default settings for Cookies and Popups are used in iOS. Exceptions
- // and all the other content setting types are not used in iOS currently. So
- // make content settings unsyncable on iOS for now.
- // TODO(lshang): address this once we have proper content settings on iOS.
+ // Don't sync settings to mobile platforms. The UI is different to desktop and
+ // doesn't allow the settings to be managed in the same way. See
+ // crbug.com/642184.
sync_status = WebsiteSettingsInfo::UNSYNCABLE;
#else
#error "Unsupported platform"

Powered by Google App Engine
This is Rietveld 408576698