third_party/WebKit/Source/core/html/HTMLSourceElement.cpp - Issue 2307353002: Remove HTMLSourceElement media listener if media attribute is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

Issue 2307353002: Remove HTMLSourceElement media listener if media attribute is empty (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

index f65e834ef53fbc00b5fdca11d4ed3da34a3eb7a1..9323ad8b47251b229a04f62da62ab4663720f0d4 100644

--- a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

@@ -81,10 +81,10 @@ HTMLSourceElement::~HTMLSourceElement()

void HTMLSourceElement::createMediaQueryList(const AtomicString& media)

{

+ removeMediaQueryListListener();

if (media.isEmpty())

return;

- removeMediaQueryListListener();

MediaQuerySet* set = MediaQuerySet::create(media);

m_mediaQueryList = MediaQueryList::create(&document(), &document().mediaQueryMatcher(), set);

cbiesinger 2016/09/07 16:01:41 Should this also be set to null if media.isEmpty()

addMediaQueryListListener();

« no previous file with comments | « no previous file | no next file » | no next file with comments »