ElementsAccessor::Delete() maybehandlified.

ElementsAccessor::Delete() maybehandlified.

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20631

[Igor Sheludko, 2014-04-09 13:34:18]

PTAL

[Yang, 2014-04-09 15:09:59]

LGTM with comments addressed.

https://codereview.chromium.org/230733003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/230733003/diff/1/src/objects.cc#newcode5212
src/objects.cc:5212: RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate, Object);
Where does the API callback happen? Could we move this check to the callback
itself?

https://codereview.chromium.org/230733003/diff/1/src/objects.cc#newcode5270
src/objects.cc:5270: maybe_result =
object->GetElementsAccessor()->Delete(object, index, mode);
Seems like here we don't do the API callback exception check.

[Igor Sheludko, 2014-04-09 15:44:54]

https://codereview.chromium.org/230733003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/230733003/diff/1/src/objects.cc#newcode5212
src/objects.cc:5212: RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate, Object);
On 2014/04/09 15:09:59, Yang wrote:
> Where does the API callback happen? Could we move this check to the callback
> itself?

I did not find any callbacks inside Delete() call graph. I think this one can be
removed.

https://codereview.chromium.org/230733003/diff/1/src/objects.cc#newcode5270
src/objects.cc:5270: maybe_result =
object->GetElementsAccessor()->Delete(object, index, mode);
On 2014/04/09 15:09:59, Yang wrote:
> Seems like here we don't do the API callback exception check.

We don't need API callback exception check for Delete().

[Igor Sheludko, 2014-04-09 15:45:19]

Committed patchset #3 manually as r20631 (presubmit successful).