Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2307253003: DevTools: enable layers pane outside of experiements. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 2 months ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: enable layers pane outside of experiements. BUG=643809

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -256 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ShortcutsScreen.js View 1 chunk +9 lines, -11 lines 1 comment Download
A + third_party/WebKit/Source/devtools/front_end/layers/LayersPane.js View 4 chunks +22 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/layers/LayersPanel.js View 1 chunk +0 lines, -186 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layers/module.json View 1 chunk +8 lines, -12 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pfeldman
4 years, 3 months ago (2016-09-03 01:50:20 UTC) #2
alph
https://codereview.chromium.org/2307253003/diff/1/third_party/WebKit/Source/devtools/front_end/components/ShortcutsScreen.js File third_party/WebKit/Source/devtools/front_end/components/ShortcutsScreen.js (left): https://codereview.chromium.org/2307253003/diff/1/third_party/WebKit/Source/devtools/front_end/components/ShortcutsScreen.js#oldcode293 third_party/WebKit/Source/devtools/front_end/components/ShortcutsScreen.js:293: if (Runtime.experiments.isEnabled("layersPanel")) { Profiler doesn't seem to work. https://codereview.chromium.org/2307253003/diff/1/third_party/WebKit/Source/devtools/front_end/layers/module.json ...
4 years, 3 months ago (2016-09-03 09:03:29 UTC) #4
caseq
4 years, 3 months ago (2016-09-07 22:25:24 UTC) #5 
https://codereview.chromium.org/2307253003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/layers/module.json (right):

https://codereview.chromium.org/2307253003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layers/module.json:13:
"dependencies": ["timeline"],
Let's reverse this dependency -- I don't think we want a small drawer view to
depend on a much bigger panel that would mostly remain unused.

Powered by Google App Engine
This is Rietveld 408576698