Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2307213002: Switch to dark red for under-invalidation pixels (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
Xianzhu
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to dark red for under-invalidation pixels In [1] we switched the under-invalidation color from red to semi-opaque magenta to differentiate under-invalidation from the red that may be present in tests. This turned out to lead to confusing results in [2] and may get mistaken for intended test results. This patch switches to fully opaque dark red which should be more noticeable as a bad result. [1] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9 [2] https://codereview.chromium.org/2305023003 Committed: https://crrev.com/816ef1aed33dc6e4afa4eeaeb10e0590a89a401e Cr-Commit-Position: refs/heads/master@{#417043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
pdr.
4 years, 3 months ago (2016-09-03 00:37:00 UTC) #2
Xianzhu
lgtm
4 years, 3 months ago (2016-09-06 16:11:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307213002/1
4 years, 3 months ago (2016-09-06 16:12:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/253512) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-06 16:14:52 UTC) #11
pdr.
Looks like the dependent patchsets are sticking. Off to the CQ
4 years, 3 months ago (2016-09-07 17:46:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307213002/1
4 years, 3 months ago (2016-09-07 17:46:55 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:30:45 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:31:50 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/816ef1aed33dc6e4afa4eeaeb10e0590a89a401e
Cr-Commit-Position: refs/heads/master@{#417043}

Powered by Google App Engine
This is Rietveld 408576698