media/mp4/mp4_stream_parser_unittest.cc - Issue 23072043: Change NeedKeyCB to use std::vector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/mp4_stream_parser_unittest.cc

Issue 23072043: Change NeedKeyCB to use std::vector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix seek_tester, demuxer_bench, and player_x11 Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/mp4_stream_parser_unittest.cc

diff --git a/media/mp4/mp4_stream_parser_unittest.cc b/media/mp4/mp4_stream_parser_unittest.cc

index fa880ac38c69c735599ff137e7510f64f6415438..816a2106e397646d9e817a2460daedba0b5d1304 100644

--- a/media/mp4/mp4_stream_parser_unittest.cc

+++ b/media/mp4/mp4_stream_parser_unittest.cc

@@ -94,11 +94,10 @@ class MP4StreamParserTest : public testing::Test {

}

void KeyNeededF(const std::string& type,

- scoped_ptr<uint8[]> init_data, int init_data_size) {

- DVLOG(1) << "KeyNeededF: " << init_data_size;

+ const std::vector<uint8>& init_data) {

+ DVLOG(1) << "KeyNeededF: " << init_data.size();

EXPECT_EQ(kMp4InitDataType, type);

- EXPECT_TRUE(init_data.get());

- EXPECT_GT(init_data_size, 0);

+ EXPECT_FALSE(init_data.empty());

}

scoped_ptr<TextTrack> AddTextTrackF(

« no previous file with comments | « media/mp4/mp4_stream_parser.cc ('k') | media/tools/demuxer_bench/demuxer_bench.cc » ('j') | no next file with comments »