Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: media/filters/pipeline_integration_test_base.cc

Issue 23072043: Change NeedKeyCB to use std::vector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix seek_tester, demuxer_bench, and player_x11 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/pipeline_integration_test_base.h ('k') | media/mp4/mp4_stream_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/pipeline_integration_test_base.cc
diff --git a/media/filters/pipeline_integration_test_base.cc b/media/filters/pipeline_integration_test_base.cc
index 31ae8ad827fea361ff8f3ddd72d0d645e2b54330..3f0910a2b8b2a4180573d4aefc609cfa5b8ed6a9 100644
--- a/media/filters/pipeline_integration_test_base.cc
+++ b/media/filters/pipeline_integration_test_base.cc
@@ -65,12 +65,10 @@ PipelineStatusCB PipelineIntegrationTestBase::QuitOnStatusCB(
void PipelineIntegrationTestBase::DemuxerNeedKeyCB(
const std::string& type,
- scoped_ptr<uint8[]> init_data,
- int init_data_size) {
- DCHECK(init_data.get());
- DCHECK_GT(init_data_size, 0);
+ const std::vector<uint8>& init_data) {
+ DCHECK(!init_data.empty());
CHECK(!need_key_cb_.is_null());
- need_key_cb_.Run(std::string(), type, init_data.Pass(), init_data_size);
+ need_key_cb_.Run(std::string(), type, init_data);
}
void PipelineIntegrationTestBase::OnEnded() {
@@ -212,7 +210,7 @@ PipelineIntegrationTestBase::CreateFilterCollection(
CHECK(file_data_source->Initialize(file_path));
data_source_.reset(file_data_source);
- media::FFmpegNeedKeyCB need_key_cb = base::Bind(
+ Demuxer::NeedKeyCB need_key_cb = base::Bind(
&PipelineIntegrationTestBase::DemuxerNeedKeyCB, base::Unretained(this));
scoped_ptr<Demuxer> demuxer(
new FFmpegDemuxer(message_loop_.message_loop_proxy(),
« no previous file with comments | « media/filters/pipeline_integration_test_base.h ('k') | media/mp4/mp4_stream_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698