Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/mp4/mp4_stream_parser_unittest.cc

Issue 23072043: Change NeedKeyCB to use std::vector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/pipeline_integration_test_base.cc ('K') | « media/mp4/mp4_stream_parser.cc ('k') | media/webm/webm_stream_parser.cc » ('j') | media/webm/webm_stream_parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mp4/mp4_stream_parser_unittest.cc
diff --git a/media/mp4/mp4_stream_parser_unittest.cc b/media/mp4/mp4_stream_parser_unittest.cc
index fa880ac38c69c735599ff137e7510f64f6415438..70d3959b8e651d87f62426c31091f7bb249a9a27 100644
--- a/media/mp4/mp4_stream_parser_unittest.cc
+++ b/media/mp4/mp4_stream_parser_unittest.cc
@@ -94,11 +94,11 @@ class MP4StreamParserTest : public testing::Test {
}
void KeyNeededF(const std::string& type,
- scoped_ptr<uint8[]> init_data, int init_data_size) {
- DVLOG(1) << "KeyNeededF: " << init_data_size;
+ const std::vector<uint8>& init_data) {
+ DVLOG(1) << "KeyNeededF: " << init_data.size();
EXPECT_EQ(kMp4InitDataType, type);
- EXPECT_TRUE(init_data.get());
- EXPECT_GT(init_data_size, 0);
+ EXPECT_TRUE(&init_data[0]);
+ EXPECT_GT(init_data.size(), 0u);
xhwang 2013/08/23 17:24:37 ditto
acolwell GONE FROM CHROMIUM 2013/08/23 19:55:28 Done.
}
scoped_ptr<TextTrack> AddTextTrackF(
« media/filters/pipeline_integration_test_base.cc ('K') | « media/mp4/mp4_stream_parser.cc ('k') | media/webm/webm_stream_parser.cc » ('j') | media/webm/webm_stream_parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698