Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 23072035: Fix restore_rt() getter's inline asm not to clobber the x86-64 red zone (Closed)

Created:
7 years, 4 months ago by Mark Seaborn
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix restore_rt() getter's inline asm not to clobber the x86-64 red zone Using "call" in x86-64 inline asm without adjusting the stack pointer for the 128 byte red zone isn't valid, because it would clobber the red zone. This use of "call" comes from the x86-32 version, but it's not necessary on x86-64 where we can use %rip-relative addressing. Also relax output constraint from using %rax ('=a') to using any register ('=r'); the stricter constraint wasn't necessary before. BUG=none TEST=none Committed: https://code.google.com/p/linux-syscall-support/source/detail?r=23

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M lss/linux_syscall_support.h View 1 chunk +4 lines, -5 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
I haven't run into any problems with this in practice, but I noticed it was ...
7 years, 4 months ago (2013-08-22 23:39:25 UTC) #1
jln (very slow on Chromium)
lgtm https://codereview.chromium.org/23072035/diff/1/lss/linux_syscall_support.h File lss/linux_syscall_support.h (right): https://codereview.chromium.org/23072035/diff/1/lss/linux_syscall_support.h#newcode2036 lss/linux_syscall_support.h:2036: : "=r" (res) This should always have been ...
7 years, 3 months ago (2013-08-29 20:22:03 UTC) #2
Mark Seaborn
https://codereview.chromium.org/23072035/diff/1/lss/linux_syscall_support.h File lss/linux_syscall_support.h (right): https://codereview.chromium.org/23072035/diff/1/lss/linux_syscall_support.h#newcode2036 lss/linux_syscall_support.h:2036: : "=r" (res) On 2013/08/29 20:22:03, Julien Tinnes wrote: ...
7 years, 3 months ago (2013-08-31 00:01:58 UTC) #3
Mark Seaborn
7 years, 3 months ago (2013-08-31 00:05:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698