Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23072026: fix cpp11 compile errors (Closed)

Created:
7 years, 4 months ago by Jacob
Modified:
7 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, vsm
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 34

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -378 lines) Patch
M runtime/bin/dbg_message.cc View 12 chunks +17 lines, -17 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/simd128.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/lib/typed_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/allocation.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/ast_printer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/bitmap.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bitmap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/class_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 15 chunks +23 lines, -21 lines 0 comments Download
M runtime/vm/compiler.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M runtime/vm/compiler_stats.cc View 1 chunk +25 lines, -25 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/dart_api_state.h View 6 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/debugger.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/deopt_instructions.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler_x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 1 18 chunks +29 lines, -27 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 15 chunks +18 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/freelist.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/handles.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/handles.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/handles_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/heap.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/heap_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap_profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/il_printer.cc View 1 20 chunks +29 lines, -28 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/locations.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/message_handler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 33 chunks +37 lines, -34 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/scanner.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 1 6 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/zone.h View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/zone.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob
Fix all c++11 compile errors How do you want me to handle the few lines ...
7 years, 4 months ago (2013-08-20 18:45:24 UTC) #1
siva
The VM style does not overlow beyond 80 characters. I have suggested possible indentation fixes. ...
7 years, 4 months ago (2013-08-20 19:54:50 UTC) #2
Jacob
Committed patchset #2 manually as r26387 (presubmit successful).
7 years, 4 months ago (2013-08-20 20:24:41 UTC) #3
Jacob
7 years, 4 months ago (2013-08-20 20:32:14 UTC) #4
Message was sent while issue was closed. 
Fixed those >80 chars lines along with a couple others found by the linter.

https://codereview.chromium.org/23072026/diff/1/runtime/lib/simd128.cc
File runtime/lib/simd128.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/lib/simd128.cc#newcod...
runtime/lib/simd128.cc:238: String::NewFormatted("mask (%" Pd64 ") must be in
the range [0..256)", m));
On 2013/08/20 19:54:51, siva wrote:
> we normally indent the next parameter over to the next line aligned
> up with the first parameter:
> 
> String::NewFormatted("mask (%" Pd64 ") must be in the range [0..256)",
>                      m));

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1010: OS::PrintErr("StaticCallMissHandler at %#" Px
" target %s (%" Pd ", %" Pd ")\n",
On 2013/08/20 19:54:51, siva wrote:
> maybe indent as:
> 
> OS::PrintErr("StaticCallMissHandler at %#" Px
>              " target %s (%" Pd ", %" Pd ")\n",

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1406: OS::PrintErr("IC call @%#" Px ": ICData: %p
cnt:%" Pd " nchecks: %" Pd " %s %s\n",
On 2013/08/20 19:54:51, siva wrote:
> OS::PrintErr("IC call @%#" Px ": ICData: %p cnt:%" Pd
>              " nchecks: %" Pd " %s %s\n",

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/dart_api_impl.h
File runtime/vm/dart_api_impl.h (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/dart_api_impl.h#ne...
runtime/vm/dart_api_impl.h:89: "%s expects argument '%s' to be in the range
[0..%" Pd "].",           \
On 2013/08/20 19:54:51, siva wrote:
> indent the \ back to align up with other backslashes

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/flow_graph_allocat...
File runtime/vm/flow_graph_allocator.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/flow_graph_allocat...
runtime/vm/flow_graph_allocator.cc:372: OS::Print("  live range v%" Pd " [%" Pd
", %" Pd ") in ", vreg(), Start(), End());
On 2013/08/20 19:54:51, siva wrote:
> indent as
> OS::Print("  live range v%" Pd " [%" Pd ", %" Pd ") in ",
>           vreg(), Start(), End());

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/flow_graph_allocat...
runtime/vm/flow_graph_allocator.cc:1502: TRACE_ALLOC(OS::Print("split v%" Pd "
[%" Pd ", %" Pd ") between [%" Pd ", %" Pd ")\n",
On 2013/08/20 19:54:51, siva wrote:
> TRACE_ALLOC(OS::Print("split v%" Pd " [%" Pd ", %" Pd
>             ") between [%" Pd ", %" Pd ")\n",

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:4182: "<v%" Pd "@%" Pd ">",
instance()->ssa_temp_index(), offset_in_bytes());
On 2013/08/20 19:54:51, siva wrote:
> "<v%" Pd "@%" Pd ">",
> instance()->ssa_temp_index(), offset_in_bytes());

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/handles.cc
File runtime/vm/handles.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/handles.cc#newcode28
runtime/vm/handles.cc:28: OS::PrintErr("***   Handle Counts for 0x(%" Px "):Zone
= %d,Scoped = %d\n",
On 2013/08/20 19:54:51, siva wrote:
> OS::PrintErr("***   Handle Counts for 0x(%" Px
>              "):Zone = %d,Scoped = %d\n",

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/heap.cc#newcode474
runtime/vm/heap.cc:474: "%" Pd ", %" Pd ", %" Pd ", %" Pd ", "  // new gen: in
use, capacity before/after
On 2013/08/20 19:54:51, siva wrote:
> "%" Pd ", %" Pd ", "  // new gen: in use before/after
> "%" Pd ", %" Pd ", "  // new gen: capacity before/after

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/heap.cc#newcode475
runtime/vm/heap.cc:475: "%" Pd ", %" Pd ", %" Pd ", %" Pd ", "  // old gen: in
use, capacity before/after
On 2013/08/20 19:54:51, siva wrote:
> "%" Pd ", %" Pd ", "  // old gen: in use before/after
> "%" Pd ", %" Pd ", "  // old gen: capacity before/after

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/il_printer.cc
File runtime/vm/il_printer.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/il_printer.cc#newc...
runtime/vm/il_printer.cc:286: f->Print("v%" Pd,
reinterpret_cast<Definition*>(value_)->ssa_temp_index());
On 2013/08/20 19:54:51, siva wrote:
> f->Print("v%" Pd,
>          reinterpret_cast<Definition*>(value_)->ssa_temp_index());

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/megamorphic_cache_...
File runtime/vm/megamorphic_cache_table.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/megamorphic_cache_...
runtime/vm/megamorphic_cache_table.cc:95: OS::Print("%" Pd " megamorphic caches
using %" Pd "KB.\n", length_, size / 1024);
On 2013/08/20 19:54:51, siva wrote:
> OS::Print("%" Pd " megamorphic caches using %" Pd "KB.\n",
>           length_, size / 1024);

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/object.cc#newcode8251
runtime/vm/object.cc:8251: const char* kFormat = "%" Pd " => %#" Px "  (%" Pd "
types) (outer %" Pd ")\n";
On 2013/08/20 19:54:51, siva wrote:
> const char* kFormat = "%" Pd " => %#" Px "  (%" Pd
>                       " types) (outer %" Pd ")\n";

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/object.cc#newcode8437
runtime/vm/object.cc:8437: FATAL1("Fatal error in Code::Comments::New: invalid
count %" Pd "\n", count);
On 2013/08/20 19:54:51, siva wrote:
> FATAL1("Fatal error in Code::Comments::New: invalid count %" Pd "\n",
>        count);

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/object.cc#newcode9050
runtime/vm/object.cc:9050: const char* kFormat = "ICData target:'%s' num-args:
%" Pd " num-checks: %" Pd "";
On 2013/08/20 19:54:51, siva wrote:
> const char* kFormat = "ICData target:'%s' num-args: %" Pd
>                       " num-checks: %" Pd "";

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:297: OS::Print("pc=0x%" Px " fp=0x%" Px " sp=0x%" Px
" %s%s (%s:%" Pd ":%" Pd ")\n",
On 2013/08/20 19:54:51, siva wrote:
> OS::Print("pc=0x%" Px " fp=0x%" Px " sp=0x%" Px " %s%s (%s:%" Pd
>           ":%" Pd ")\n",

Done.

https://codereview.chromium.org/23072026/diff/1/runtime/vm/timer.cc
File runtime/vm/timer.cc (right):

https://codereview.chromium.org/23072026/diff/1/runtime/vm/timer.cc#newcode29
runtime/vm/timer.cc:29: OS::Print("%s %" Pd64 " micros.\n",                     
                    \
On 2013/08/20 19:54:51, siva wrote:
> Indent the backslash back to align with other backslashes

Done.

Powered by Google App Engine
This is Rietveld 408576698