Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 23072008: aura: Allow in process ContextProvider to hold onscreen contexts. (Closed)

Created:
7 years, 4 months ago by danakj
Modified:
7 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, boliu, jbauman, no sievers
Visibility:
Public.

Description

aura: Allow in process ContextProvider to hold onscreen contexts. This will allow us to use them in an OutputSurface. For the common offscreen context case, we want to still share code so add a CreateOffscreen() method to the context provider so we don't have to replicate the WGC3D::Attributes decisions around the codebase. R=piman@chromium.org BUG=258625 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217677

Patch Set 1 #

Total comments: 2

Patch Set 2 : inprocesscreatecallback: android #

Patch Set 3 : inprocesscreatecallback: nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -47 lines) Patch
M cc/test/layer_tree_pixel_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/test/pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 2 chunks +13 lines, -8 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 3 chunks +34 lines, -13 lines 0 comments Download
M webkit/common/gpu/test_context_provider_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +13 lines, -10 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 4 months ago (2013-08-14 04:03:39 UTC) #1
boliu
https://codereview.chromium.org/23072008/diff/1/webkit/common/gpu/context_provider_in_process.h File webkit/common/gpu/context_provider_in_process.h (right): https://codereview.chromium.org/23072008/diff/1/webkit/common/gpu/context_provider_in_process.h#newcode36 webkit/common/gpu/context_provider_in_process.h:36: static scoped_refptr<ContextProviderInProcess> CreateOffscreen(); Need to update the android-only synchronous_compositor_impl.cc, ...
7 years, 4 months ago (2013-08-14 04:09:26 UTC) #2
danakj
https://codereview.chromium.org/23072008/diff/1/webkit/common/gpu/context_provider_in_process.h File webkit/common/gpu/context_provider_in_process.h (right): https://codereview.chromium.org/23072008/diff/1/webkit/common/gpu/context_provider_in_process.h#newcode36 webkit/common/gpu/context_provider_in_process.h:36: static scoped_refptr<ContextProviderInProcess> CreateOffscreen(); On 2013/08/14 04:09:27, boliu wrote: > ...
7 years, 4 months ago (2013-08-14 04:10:40 UTC) #3
piman
lgtm
7 years, 4 months ago (2013-08-14 20:23:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/23072008/27001
7 years, 4 months ago (2013-08-14 20:59:09 UTC) #5
danakj
7 years, 4 months ago (2013-08-14 22:25:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r217677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698