Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2307183002: Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (Closed)

Created:
4 years, 3 months ago by skia-deps-roller
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
chromium-reviews, bsalomon
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=bsalomon@google.com Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 Cr-Commit-Position: refs/heads/master@{#416414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
skia-deps-roller
4 years, 3 months ago (2016-09-02 23:17:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307183002/1
4 years, 3 months ago (2016-09-02 23:17:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-03 00:41:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 Cr-Commit-Position: refs/heads/master@{#416414}
4 years, 3 months ago (2016-09-03 00:44:43 UTC) #6
magjed_chromium
4 years, 3 months ago (2016-09-05 08:51:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2311803002/ by magjed@chromium.org.

The reason for reverting is: This roll introduced two static initializers
(gAdobeRGB and gSRGB) which are causing size regression on Chromium builders:
https://build.chromium.org/p/chromium/builders/Mac
https://build.chromium.org/p/chromium/builders/Linux%20x64.

Powered by Google App Engine
This is Rietveld 408576698