Remove non-layer-list codepath from PaintArtifactCompositor

Remove non-layer-list codepath from PaintArtifactCompositor

Slimming paint v2 only uses layer lists now and the old non-layer-list
codepath can be removed.

BUG=630691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/4111dba812f24996262b71c76dd98a7eecb8f71a
Cr-Commit-Position: refs/heads/master@{#416489}

[pdr., 2016-09-02 20:51:16]

Description was changed from

==========
Remove non-layer-list codepath from PaintArtifactCompositor

BUG=630691
==========

to

==========
Remove non-layer-list codepath from PaintArtifactCompositor

BUG=630691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-02 21:07:05]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[pdr., 2016-09-02 21:07:20]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, jbroman@chromium.org

[pdr., 2016-09-02 21:07:41]

Jeremy, do you have a minute to give this a high-level review?

[commit-bot: I haz the power, 2016-09-02 21:08:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:21:11]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pdr., 2016-09-02 22:19:02]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:19:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 22:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 22:54:53]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[pdr., 2016-09-03 02:47:31]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 02:47:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 03:59:17]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-09-04 20:27:11]

lgtm

https://codereview.chromium.org/2307143002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/StubChromeClientForSPv2.h (right):

https://codereview.chromium.org/2307143002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/StubChromeClientForSPv2.h:18: : public
EmptyChromeClient {
super-nit: why wrap this?

[pdr., 2016-09-05 01:22:43]

Description was changed from

==========
Remove non-layer-list codepath from PaintArtifactCompositor

BUG=630691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove non-layer-list codepath from PaintArtifactCompositor

Slimming paint v2 only uses layer lists now and the old non-layer-list
codepath can be removed.

BUG=630691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-05 01:28:19]

Thanks for the review!

Chrishtr also reviewed this Friday and was happy overall, so I'm going to go
ahead and land this.

https://codereview.chromium.org/2307143002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/StubChromeClientForSPv2.h (right):

https://codereview.chromium.org/2307143002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/StubChromeClientForSPv2.h:18: : public
EmptyChromeClient {
On 2016/09/04 at 20:27:11, jbroman wrote:
> super-nit: why wrap this?

This was just a mistake, fixed.

[pdr., 2016-09-05 01:28:35]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-09-05 01:28:36]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2307143002/#ps60001
(title: "Formatting cleanup")

[commit-bot: I haz the power, 2016-09-05 01:28:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 02:58:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-05 02:59:21]

Description was changed from

==========
Remove non-layer-list codepath from PaintArtifactCompositor

Slimming paint v2 only uses layer lists now and the old non-layer-list
codepath can be removed.

BUG=630691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove non-layer-list codepath from PaintArtifactCompositor

Slimming paint v2 only uses layer lists now and the old non-layer-list
codepath can be removed.

BUG=630691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/4111dba812f24996262b71c76dd98a7eecb8f71a
Cr-Commit-Position: refs/heads/master@{#416489}
==========

[commit-bot: I haz the power, 2016-09-05 02:59:22]

Patchset 4 (id:??) landed as
https://crrev.com/4111dba812f24996262b71c76dd98a7eecb8f71a
Cr-Commit-Position: refs/heads/master@{#416489}