Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: net/cert/ct_log_verifier.cc

Issue 230713002: Certificate Transparency: Parse Signed Tree Heads and validate them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing more of Ryan's comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_log_verifier.h ('k') | net/cert/ct_log_verifier_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_log_verifier.cc
diff --git a/net/cert/ct_log_verifier.cc b/net/cert/ct_log_verifier.cc
index 1c9374dfd941baf7bcff7bad5cfa8fbda633f788..6efb96a93192d1001a74a3019f20cc06acc0a949 100644
--- a/net/cert/ct_log_verifier.cc
+++ b/net/cert/ct_log_verifier.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "net/cert/ct_serialization.h"
+#include "net/cert/signed_tree_head.h"
namespace net {
@@ -26,17 +27,8 @@ bool CTLogVerifier::Verify(const ct::LogEntry& entry,
return false;
}
- if (sct.signature.hash_algorithm != hash_algorithm_) {
- DVLOG(1) << "Mismatched hash algorithm. Expected " << hash_algorithm_
- << ", got " << sct.signature.hash_algorithm << ".";
+ if (!SignatureParametersMatch(sct.signature))
return false;
- }
-
- if (sct.signature.signature_algorithm != signature_algorithm_) {
- DVLOG(1) << "Mismatched sig algorithm. Expected " << signature_algorithm_
- << ", got " << sct.signature.signature_algorithm << ".";
- return false;
- }
std::string serialized_log_entry;
if (!ct::EncodeLogEntry(entry, &serialized_log_entry)) {
@@ -53,4 +45,33 @@ bool CTLogVerifier::Verify(const ct::LogEntry& entry,
return VerifySignature(serialized_data, sct.signature.signature_data);
}
+bool CTLogVerifier::SetSignedTreeHead(
+ scoped_ptr<ct::SignedTreeHead> signed_tree_head) {
+ if (!SignatureParametersMatch(signed_tree_head->signature))
+ return false;
+
+ std::string serialized_data;
+ ct::EncodeTreeHeadSignature(*signed_tree_head.get(), &serialized_data);
+ if (VerifySignature(serialized_data,
+ signed_tree_head->signature.signature_data)) {
+ signed_tree_head_.reset(signed_tree_head.release());
+ return true;
+ }
+ return false;
+}
+
+bool CTLogVerifier::SignatureParametersMatch(
+ const ct::DigitallySigned& signature) {
+ if (!signature.SignatureParametersMatch(hash_algorithm_,
+ signature_algorithm_)) {
+ DVLOG(1) << "Mismatched hash or signature algorithm. Hash: "
+ << hash_algorithm_ << " vs " << signature.hash_algorithm
+ << " Signature: " << signature_algorithm_ << " vs "
+ << signature.signature_algorithm << ".";
+ return false;
+ }
+
+ return true;
+}
+
} // namespace net
« no previous file with comments | « net/cert/ct_log_verifier.h ('k') | net/cert/ct_log_verifier_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698