Make Range::selectNode() and Range::surroundContents() to work with detached node

Source/core/dom/Range.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Gunnstein Lye (gunnstein@netcom.no)
  * (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
  * (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 1308 matching lines @@
             break;
         case Node::ATTRIBUTE_NODE:
         case Node::DOCUMENT_FRAGMENT_NODE:
         case Node::DOCUMENT_NODE:
         case Node::ENTITY_NODE:
         case Node::NOTATION_NODE:
             es.throwDOMException(InvalidNodeTypeError);
             return;
     }
 
+    if (!refNode->parentNode()) {
+        es.throwDOMException(InvalidNodeTypeError);

[Mike West, 2013/08/22 08:17:11]

1. Perhaps you could move this up above the for loop, next to the other
early-exit checks?

2. I'm in the process of improving error messages. :) Can you please help out by
adding a more detailed exception message to this new item? For example
`ExceptionMessages::failedToExecute("selectNode", "Range", "the given Node has
no parent.")`.

[yosin_UTC9, 2013/08/22 09:48:44]

Done.

+        return;
+    }
+
     if (m_ownerDocument != refNode->document())
         setDocument(refNode->document());
 
-    setStartBefore(refNode, es);
+    setStart(refNode->parentNode(), refNode->nodeIndex(), es);

[Mike West, 2013/08/22 08:17:11]

Can this throw an exception, given the node-type checks above? If not, it might
be better to pass in ASSERT_NO_EXCEPTION.

[yosin_UTC9, 2013/08/22 09:48:44]

Done.

[Mike West, 2013/08/22 10:23:47]

This was an honest question. I don't think it can throw, but I haven't looked at
it carefully. Throwing this patch to the debug bot to see if explodes. :)

     if (es.hadException())
         return;
-    setEndAfter(refNode, es);
+    setEnd(refNode->parentNode(), refNode->nodeIndex() + 1, es);

[Mike West, 2013/08/22 08:17:11]

Same here.

[yosin_UTC9, 2013/08/22 09:48:44]

Done.

 }
 
 void Range::selectNodeContents(Node* refNode, ExceptionState& es)
 {
     if (!m_start.container()) {
         es.throwDOMException(InvalidStateError);
         return;
     }
 
     if (!refNode) {
@@ skipping 570 matching lines @@
 
 void showTree(const WebCore::Range* range)
 {
     if (range && range->boundaryPointsValid()) {
         range->startContainer()->showTreeAndMark(range->startContainer(), "S", range->endContainer(), "E");
         fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset(), range->endOffset());
     }
 }
 
 #endif