chrome/browser/extensions/api/alarms/alarms_api.cc - Issue 23071003: Delta from the first fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/alarms/alarms_api.cc

Issue 23071003: Delta from the first fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/alarms/alarms_api.cc

diff --git a/chrome/browser/extensions/api/alarms/alarms_api.cc b/chrome/browser/extensions/api/alarms/alarms_api.cc

index 0d03ba7ed2f20c647858583613efc76b933acc1c..cc49b6ed466b1bec4e0743682cb060087b43956d 100644

--- a/chrome/browser/extensions/api/alarms/alarms_api.cc

+++ b/chrome/browser/extensions/api/alarms/alarms_api.cc

@@ -108,7 +108,6 @@ bool AlarmsCreateFunction::RunImpl() {

std::vector<std::string> warnings;

if (!ValidateAlarmCreateInfo(

alarm_name, params->alarm_info, GetExtension(), &error_, &warnings)) {

- SendResponse(false);

return false;

}

for (std::vector<std::string>::const_iterator it = warnings.begin();