Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 23071002: Deletes warning on no graph outputs, since we don't output graphs anymore. (Closed)

Created:
7 years, 4 months ago by benchen
Modified:
7 years, 4 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com, skiabot_google.com
Visibility:
Public.

Description

Deletes warning on no graph outputs, since we don't output graphs anymore. Committed: https://code.google.com/p/skia/source/detail?r=10717

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M bench/bench_graph_svg.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benchen
Assuming team is fine with it..
7 years, 4 months ago (2013-08-13 14:54:42 UTC) #1
scroggo
lgtm https://codereview.chromium.org/23071002/diff/1/bench/bench_graph_svg.py File bench/bench_graph_svg.py (left): https://codereview.chromium.org/23071002/diff/1/bench/bench_graph_svg.py#oldcode503 bench/bench_graph_svg.py:503: if not output_path: Should we take it a ...
7 years, 4 months ago (2013-08-13 14:58:19 UTC) #2
benchen
Thanks Leon! I changed the CL description to remove SkipBuildbotRuns. https://codereview.chromium.org/23071002/diff/1/bench/bench_graph_svg.py File bench/bench_graph_svg.py (left): https://codereview.chromium.org/23071002/diff/1/bench/bench_graph_svg.py#oldcode503 ...
7 years, 4 months ago (2013-08-13 15:00:37 UTC) #3
benchen
7 years, 4 months ago (2013-08-14 18:37:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r10717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698