Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2307083002: Cleanup: move WebRTC related files from chrome/browser/media to chrome/browser/media/webrtc/ (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
CC:
chromium-reviews, msramek+watch_chromium.org, skanuj+watch_chromium.org, sadrul, oshima+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, markusheintz_, michaelpg+watch-md-settings_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, achuith+watch_chromium.org, raymes+watch_chromium.org, tburkard+watch_chromium.org, rlp+watch_chromium.org, chromium-apps-reviews_chromium.org, tnakamura+watch_chromium.org, dbeam+watch-options_chromium.org, alemate+watch_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, mcasas+watch+vc_chromium.org, kalyank, mlamouri+watch-permissions_chromium.org, Jered, michaelpg+watch-options_chromium.org, feature-media-reviews_chromium.org, tfarina, donnd+watch_chromium.org, phoglund+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: move WebRTC related files from chrome/browser/media to chrome/browser/media/webrtc/ The WebRTC related files under chrome/browser/media are isolated from "the rest" of the folder, i.e. do not include other files and "the rest" don't include webrtc-related files; there's 130 files in media/ folder, of which 85 are webrtc-specific, so this CL extracts these WebRTC files (i.e. having to do with Media Stream, WebRTC, Desktop/Tab capture and capture permissions) into its own folder. No new code whatsoever. Splitted OWNERS and DEPS. TBR= stevenjb@chromium.org for for chrome/browser/ui/webui/options/media_devices_selection_handler.h that has a noparent in the OWNERS file, and anyway says : "# This UI is deprecated." Committed: https://crrev.com/a2023abe2a2932c1bc9ae39106f983f292980242 Cr-Commit-Position: refs/heads/master@{#417136}

Patch Set 1 : #

Patch Set 2 : moved files into chrome/browser/media/webrtc #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : Removed file wrongly resuscitated during rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -16246 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 12 chunks +58 lines, -57 lines 0 comments Download
M chrome/browser/android/tab_web_contents_delegate_android.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/status_uploader.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc View 1 3 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/DEPS View 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/media/OWNERS View 3 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/media/audio_debug_recordings_handler.cc View 3 1 chunk +0 lines, -156 lines 0 comments Download
M chrome/browser/media/capture_access_handler_base.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/combined_desktop_media_list.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/combined_desktop_media_list_unittest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/media/desktop_capture_access_handler.h View 3 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/media/desktop_capture_access_handler.cc View 3 1 chunk +0 lines, -435 lines 0 comments Download
D chrome/browser/media/desktop_media_list.h View 3 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/media/desktop_media_list_ash.h View 3 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/media/desktop_media_list_ash.cc View 3 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/browser/media/desktop_media_list_ash_unittest.cc View 3 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/media/desktop_media_list_base.h View 3 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/media/desktop_media_list_base.cc View 3 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/media/desktop_media_list_observer.h View 3 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/media/desktop_media_picker.h View 3 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/media/desktop_streams_registry.h View 3 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/media/desktop_streams_registry.cc View 3 1 chunk +0 lines, -91 lines 0 comments Download
M chrome/browser/media/extension_media_access_handler.cc View 1 3 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/media/fake_desktop_media_list.h View 1 3 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/media/fake_desktop_media_list.cc View 1 3 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/media/media_capture_devices_dispatcher.h View 3 1 chunk +0 lines, -206 lines 0 comments Download
D chrome/browser/media/media_capture_devices_dispatcher.cc View 3 1 chunk +0 lines, -443 lines 0 comments Download
D chrome/browser/media/media_permission.h View 3 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/media/media_permission.cc View 3 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/media/media_stream_capture_indicator.h View 3 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/media/media_stream_capture_indicator.cc View 3 1 chunk +0 lines, -441 lines 0 comments Download
D chrome/browser/media/media_stream_device_permission_context.h View 3 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/media/media_stream_device_permission_context.cc View 3 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/media/media_stream_device_permission_context_unittest.cc View 3 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/media/media_stream_device_permissions.h View 3 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/media/media_stream_device_permissions.cc View 3 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/media/media_stream_devices_controller.h View 3 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/media/media_stream_devices_controller.cc View 3 1 chunk +0 lines, -649 lines 0 comments Download
D chrome/browser/media/media_stream_devices_controller_browsertest.cc View 3 1 chunk +0 lines, -734 lines 0 comments Download
D chrome/browser/media/media_stream_infobar_browsertest.cc View 3 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/media/media_stream_infobar_delegate_android.h View 3 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/media/media_stream_infobar_delegate_android.cc View 3 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/media/native_desktop_media_list.h View 3 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/media/native_desktop_media_list.cc View 3 1 chunk +0 lines, -376 lines 0 comments Download
D chrome/browser/media/native_desktop_media_list_unittest.cc View 3 1 chunk +0 lines, -517 lines 0 comments Download
M chrome/browser/media/output_protection_proxy.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/media/permission_bubble_media_access_handler.h View 3 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/media/permission_bubble_media_access_handler.cc View 3 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/media/rtp_dump_type.h View 3 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/media/tab_capture_access_handler.h View 3 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/media/tab_capture_access_handler.cc View 3 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/media/tab_desktop_media_list.h View 3 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/media/tab_desktop_media_list.cc View 3 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/media/tab_desktop_media_list_unittest.cc View 3 1 chunk +0 lines, -362 lines 0 comments Download
A + chrome/browser/media/webrtc/DEPS View 1 3 1 chunk +0 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/OWNERS View 1 3 1 chunk +1 line, -6 lines 0 comments Download
A + chrome/browser/media/webrtc/audio_debug_recordings_handler.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/desktop_capture_access_handler.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_capture_access_handler.cc View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list_ash.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list_ash.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list_base.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list_base.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_list_observer.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_media_picker.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_streams_registry.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/desktop_streams_registry.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/fake_desktop_media_list.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/fake_desktop_media_list.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/media_capture_devices_dispatcher.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc View 1 3 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/media/webrtc/media_permission.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_permission.cc View 1 3 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_capture_indicator.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_capture_indicator.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/media_stream_device_permission_context.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_device_permission_context.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/media_stream_device_permissions.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_device_permissions.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/media_stream_devices_controller.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 3 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc View 1 3 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_infobar_browsertest.cc View 1 3 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/native_desktop_media_list.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/native_desktop_media_list.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/permission_bubble_media_access_handler.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc View 1 3 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/media/webrtc/rtp_dump_type.h View 1 3 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/tab_capture_access_handler.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/tab_capture_access_handler.cc View 1 3 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/tab_desktop_media_list.h View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/tab_desktop_media_list.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc View 1 3 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_audio.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_audio.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_base.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_common.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_common.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_perf.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_browsertest_perf.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_disable_encryption_flag_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_event_log_handler.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_event_log_handler.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_list.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_list.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_uploader.h View 1 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_uploader.cc View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_util.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_util.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_log_util_unittest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_logging_handler_host.h View 1 3 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_logging_handler_host.cc View 1 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_perf_browsertest.cc View 1 3 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_rtp_dump_handler.h View 1 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_rtp_dump_handler.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_rtp_dump_handler_unittest.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_rtp_dump_writer.h View 1 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_rtp_dump_writer.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_rtp_dump_writer_unittest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/webrtc_simulcast_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media/webrtc/window_icon_util.h View 1 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/webrtc/window_icon_util_chromeos.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/window_icon_util_mac.mm View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/window_icon_util_win.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media/webrtc/window_icon_util_x11.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/media/webrtc_apprtc_browsertest.cc View 3 1 chunk +0 lines, -305 lines 0 comments Download
D chrome/browser/media/webrtc_audio_quality_browsertest.cc View 3 1 chunk +0 lines, -823 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest.cc View 3 1 chunk +0 lines, -210 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_audio.h View 3 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_audio.cc View 3 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_base.h View 3 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_base.cc View 3 1 chunk +0 lines, -478 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_common.h View 3 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_common.cc View 3 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_perf.h View 3 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/media/webrtc_browsertest_perf.cc View 3 1 chunk +0 lines, -281 lines 0 comments Download
D chrome/browser/media/webrtc_disable_encryption_flag_browsertest.cc View 3 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/media/webrtc_event_log_handler.h View 3 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/media/webrtc_event_log_handler.cc View 3 1 chunk +0 lines, -148 lines 0 comments Download
D chrome/browser/media/webrtc_getmediadevices_browsertest.cc View 3 1 chunk +0 lines, -295 lines 0 comments Download
D chrome/browser/media/webrtc_log_list.h View 3 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/media/webrtc_log_list.cc View 3 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/media/webrtc_log_uploader.h View 3 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/browser/media/webrtc_log_uploader.cc View 3 1 chunk +0 lines, -601 lines 0 comments Download
D chrome/browser/media/webrtc_log_uploader_unittest.cc View 3 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/browser/media/webrtc_log_util.h View 3 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/media/webrtc_log_util.cc View 3 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/media/webrtc_log_util_unittest.cc View 3 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/media/webrtc_logging_handler_host.h View 3 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/browser/media/webrtc_logging_handler_host.cc View 3 1 chunk +0 lines, -807 lines 0 comments Download
D chrome/browser/media/webrtc_perf_browsertest.cc View 3 1 chunk +0 lines, -265 lines 0 comments Download
D chrome/browser/media/webrtc_rtp_dump_handler.h View 3 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/media/webrtc_rtp_dump_handler.cc View 3 1 chunk +0 lines, -345 lines 0 comments Download
D chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc View 3 1 chunk +0 lines, -419 lines 0 comments Download
D chrome/browser/media/webrtc_rtp_dump_writer.h View 3 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/media/webrtc_rtp_dump_writer.cc View 3 1 chunk +0 lines, -453 lines 0 comments Download
D chrome/browser/media/webrtc_rtp_dump_writer_unittest.cc View 3 1 chunk +0 lines, -369 lines 0 comments Download
D chrome/browser/media/webrtc_simulcast_browsertest.cc View 3 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/media/webrtc_video_quality_browsertest.cc View 3 1 chunk +0 lines, -369 lines 0 comments Download
D chrome/browser/media/webrtc_webcam_browsertest.cc View 3 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/media/window_icon_util.h View 3 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/media/window_icon_util_chromeos.cc View 3 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/media/window_icon_util_mac.mm View 3 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/media/window_icon_util_win.cc View 3 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/media/window_icon_util_x11.cc View 3 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_keyboard_ui.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/media_delegate_chromeos.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/media_delegate_chromeos.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_bridge.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated_unittest.mm View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_media_menu_model.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/media_utils.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_deprecated.h View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_deprecated.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media/webrtc_logs_ui.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/media_devices_selection_handler.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 7 chunks +36 lines, -36 lines 0 comments Download

Messages

Total messages: 44 (28 generated)
mcasas
tommi@, dalecurtis@ Owners RS/PTAL
4 years, 3 months ago (2016-09-02 16:49:09 UTC) #5
tommi (sloooow) - chröme
content/renderer/media has a 'webrtc' folder. Would content/browser/media/webrtc then make sense or do you prefer content/browser/webrtc?
4 years, 3 months ago (2016-09-05 13:19:02 UTC) #9
mcasas
On 2016/09/05 13:19:02, tommi (chrömium) wrote: > content/renderer/media has a 'webrtc' folder. Would > content/browser/media/webrtc ...
4 years, 3 months ago (2016-09-06 23:16:57 UTC) #16
mcasas
On 2016/09/06 23:16:57, mcasas wrote: > On 2016/09/05 13:19:02, tommi (chrömium) wrote: > > content/renderer/media ...
4 years, 3 months ago (2016-09-07 17:22:19 UTC) #18
tommi (sloooow) - chröme
On 2016/09/07 17:22:19, mcasas wrote: > On 2016/09/06 23:16:57, mcasas wrote: > > On 2016/09/05 ...
4 years, 3 months ago (2016-09-07 17:41:47 UTC) #19
mcasas
sky@ RS plz (moving files in a subfolder for better browsing and mental tidiness)
4 years, 3 months ago (2016-09-07 17:47:18 UTC) #21
sky
https://codereview.chromium.org/2307083002/diff/150001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/2307083002/diff/150001/chrome/chrome_tests_unit.gypi#newcode1 chrome/chrome_tests_unit.gypi:1: # Copyright 2012 The Chromium Authors. All rights reserved. ...
4 years, 3 months ago (2016-09-07 19:33:55 UTC) #22
mcasas
On 2016/09/07 19:33:55, sky wrote: > https://codereview.chromium.org/2307083002/diff/150001/chrome/chrome_tests_unit.gypi > File chrome/chrome_tests_unit.gypi (right): > > https://codereview.chromium.org/2307083002/diff/150001/chrome/chrome_tests_unit.gypi#newcode1 > ...
4 years, 3 months ago (2016-09-07 21:15:36 UTC) #23
sky
RS LGTM
4 years, 3 months ago (2016-09-07 21:54:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307083002/160001
4 years, 3 months ago (2016-09-08 00:07:43 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/255066)
4 years, 3 months ago (2016-09-08 00:14:16 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307083002/160001
4 years, 3 months ago (2016-09-08 00:37:41 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/255106)
4 years, 3 months ago (2016-09-08 00:43:32 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307083002/160001
4 years, 3 months ago (2016-09-08 00:58:15 UTC) #40
commit-bot: I haz the power
Committed patchset #4 (id:160001)
4 years, 3 months ago (2016-09-08 01:07:18 UTC) #42
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:08:48 UTC) #44
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a2023abe2a2932c1bc9ae39106f983f292980242
Cr-Commit-Position: refs/heads/master@{#417136}

Powered by Google App Engine
This is Rietveld 408576698