Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache.

Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a flag set by resource cache when it wants to flush that is checked after each draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002

Committed: https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744
Committed: https://skia.googlesource.com/skia/+/b77a907c2fb4402b7e70e9fff70eb71482354e67

[bsalomon, 2016-09-02 14:34:34]

Description was changed from

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.
==========

to

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002
==========

[bsalomon, 2016-09-02 14:53:01]

Description was changed from

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002
==========

to

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002
==========

[bsalomon, 2016-09-02 14:53:01]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-09-02 14:53:34]

Description was changed from

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002
==========

to

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002
==========

[robertphillips, 2016-09-02 16:23:06]

lgtm

https://codereview.chromium.org/2307053002/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/2307053002/diff/20001/include/gpu/GrContext.h...
include/gpu/GrContext.h:375: // Set by OverbudgetCB() to request that GrContext
flush before exiting a draw.
Can we remove this too ?

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrDrawingManage...
File src/gpu/GrDrawingManager.cpp (right):

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrDrawingManage...
src/gpu/GrDrawingManager.cpp:130: fFlushState.reset();
// We always have to notify the cache when it requested a flush so it can reset
its state

?

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrDrawingManage...
src/gpu/GrDrawingManager.h:53: void flushIfNecessary() {
What happened to "this->caps()->immediateFlush()" ?

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrResourceCache...
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrResourceCache...
src/gpu/GrResourceCache.cpp:503: if (stillOverbudget) {
GrDrawingManager ?

https://codereview.chromium.org/2307053002/diff/20001/src/gpu/GrResourceCache...
src/gpu/GrResourceCache.cpp:624: fRequestFlush = false;
pull out purgeAsNeeds calls and just have one at the end?

[bsalomon, 2016-09-06 19:13:17]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-06 19:13:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2307053002/#ps60001
(title: "fix whitespace")

[commit-bot: I haz the power, 2016-09-06 19:13:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 19:38:07]

Description was changed from

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002
==========

to

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002

Committed:
https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744
==========

[commit-bot: I haz the power, 2016-09-06 19:38:08]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744

[bsalomon, 2016-09-06 20:49:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2312123003/ by bsalomon@google.com.

The reason for reverting is: Causing assertions on bots.

[bsalomon, 2016-09-07 14:04:04]

Description was changed from

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002

Committed:
https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744
==========

to

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002

Committed:
https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744
==========

[bsalomon, 2016-09-07 16:21:35]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-07 16:21:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2307053002/#ps80001
(title: "Fix uninit vars")

[commit-bot: I haz the power, 2016-09-07 16:21:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:02:05]

Description was changed from

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002

Committed:
https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744
==========

to

==========
Restructure flushing relationship between GrContext, GrDrawingManager, and
GrResourceCache.

Consolidates all flush actions into GrDrawingManager and makes GrContext::flush
a passthrough.

Removes the unused and untested discard flush variation.

Replaces the indirect overbudget callback mechanism of GrResourceCache with a
flag set by resource cache when it wants to flush that is checked after each
draw by GrDrawContext.

Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating
whether it triggered the
flush that just occurred.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002

Committed:
https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744
Committed:
https://skia.googlesource.com/skia/+/b77a907c2fb4402b7e70e9fff70eb71482354e67
==========

[commit-bot: I haz the power, 2016-09-07 17:02:07]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b77a907c2fb4402b7e70e9fff70eb71482354e67