third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp - Issue 2307003002: Move collectGarbage* methods to ThreadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp

Issue 2307003002: Move collectGarbage* methods to ThreadState (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/mhtml/MHTMLFuzzer.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp

diff --git a/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp b/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp

index 8fba292281613a4893fe91b271437d0193af6054..a189e3f75d8cc9d579875fe89515af856db3df85 100644

--- a/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp

+++ b/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp

@@ -216,7 +216,7 @@ TEST(CancellableTaskFactoryTest, GarbageCollectedWeak)

GCObject* object = new GCObject();

std::unique_ptr<WebTaskRunner::Task> task = wrapUnique(object->m_factory->cancelAndCreate());

object = nullptr;

- ThreadHeap::collectAllGarbage();

+ ThreadState::current()-> collectAllGarbage();

task->run();

// The owning object will have been GCed and the task will have

// lost its weak reference. Verify that it wasn't invoked.