third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp - Issue 2307003002: Move collectGarbage* methods to ThreadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

Issue 2307003002: Move collectGarbage* methods to ThreadState (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

index 794cf74ec6f3d1a82a3d18d5a4be53babdcb59b3..e8aaf899837d61226a13fe5fa060bb16e1793664 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

@@ -59,7 +59,7 @@ bool BlinkGCMemoryDumpProvider::OnMemoryDump(const base::trace_event::MemoryDump

// In the case of a detailed dump perform a mark-only GC pass to collect

// more detailed stats.

if (levelOfDetail == MemoryDumpLevelOfDetail::DETAILED)

- ThreadHeap::collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::TakeSnapshot, BlinkGC::ForcedGC);

+ ThreadState::current()->collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::TakeSnapshot, BlinkGC::ForcedGC);

dumpMemoryTotals(memoryDump);

if (m_isHeapProfilingEnabled) {

« no previous file with comments | « third_party/WebKit/Source/platform/LifecycleContextTest.cpp ('k') | third_party/WebKit/Source/platform/heap/Heap.h » ('j') | no next file with comments »